[#24712] - Update to default.php: removed nowrap class to allow wrapping title…
- Fixed in Code Base
- 16 May 2019
- Medium
- Build: staging
- # 24712
- Diff
- kofaysi:staging
User tests: Successful: Unsuccessful:
…and alias
Pull Request for Issue #24650.
Testing Instructions
Create a contact with a name/title of 200+ characters
Expected result
The title and the alias will wrap, long words will break.
Actual result
The title and the alias does not wrap and pushes other parameters (access, hits, language, ID) behind the right edge of the screen.
Documentation Changes Required
IDK about any.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
a break-word class has to be added a line below the current change
<div class="pull-left break-word">
But I do not understand how can I change the existing PR. I can create a new PR, but is that the right approach?
i don't know but pretts aure a dev will answer.
Unfortunately, I'm making changes and PRs through the web interface. Looking into the existing PR, I cannot make changes to the code.
So, please, if you feel so, make a change. Thank you!
Go to https://github.com/kofaysi/joomla-cms
Select the branch - in this case it is staging
Make the changes you want there and they will appear here
@kofaysi you can follow what @brianteeman suggested
| Labels |
Added:
?
|
||
Thank you for the suggestion. Changes are made and pushed. (Well, that was very straightforward.)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-16 04:37:58 |
| Closed_By | ⇒ | SniperSister |
Merged, thank you for contribution, it's much appreciated!
I have tested this item? unsuccessfully on 2643f7a
Without PR
With PR
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.