?

Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
22 Apr 2019

Pull Request for Issue # #24679 (comment) .

Summary of Changes

Remove unnecessary where clause from delete statement when purging finder taxonomy maps to avoid SQL error on PostgreSQL databases.

There is no need for a where clause in that SQL statement, and the existing where clause 1 will cause an error on PostgreSQL databases, see issue #24679 and PR #24682 for another issue caused by the same kind of condition 1 in a where clause.

Testing Instructions

Code review: There is no need for a where clause in that SQL statement.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 22 Apr 2019
avatar richard67 richard67 - change - 22 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category Administration com_finder
avatar richard67 richard67 - change - 22 Apr 2019
Title
Remove unnecessary where clause from delete statement when purging finder taxonomy maps to avoid SQL error on PostgreSQL databases
Remove unnecessary where clause to avoid SQL error on PostgreSQL databases
avatar richard67 richard67 - edited - 22 Apr 2019
avatar richard67
richard67 - comment - 22 Apr 2019

@twister65 Could you check this one here, too? Is just a code review. Is obvious.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24683.

avatar zero-24 zero-24 - change - 22 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 13:11:28
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 22 Apr 2019
avatar zero-24 zero-24 - merge - 22 Apr 2019
avatar zero-24
zero-24 - comment - 22 Apr 2019

Merging on review thanks 👍

avatar richard67
richard67 - comment - 22 Apr 2019

Thanks.

Add a Comment

Login with GitHub to post a comment