? ?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Apr 2019

The Reset buttons were links when they should be buttons for a11y. A nice side effect of the change is that they get the correct styling at the same time.

Test instructions

View source and see that the text is now white

Before

image

Affer

image

avatar brianteeman brianteeman - open - 22 Apr 2019
avatar brianteeman brianteeman - change - 22 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category Administration com_banners
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Apr 2019
Title
[4.0] Banner impressions [a11y]
[4.0] Banner impressions
avatar franz-wohlkoenig franz-wohlkoenig - edited - 22 Apr 2019
avatar Quy
Quy - comment - 22 Apr 2019

I have tested this item successfully on 791786d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24684.

avatar Quy Quy - test_item - 22 Apr 2019 - Tested successfully
avatar wilsonge wilsonge - change - 22 Apr 2019
Labels Added: ? ?
avatar wilsonge wilsonge - change - 22 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 22:06:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Apr 2019
avatar wilsonge wilsonge - merge - 22 Apr 2019
avatar wilsonge
wilsonge - comment - 22 Apr 2019

Thanks!

avatar brianteeman
brianteeman - comment - 22 Apr 2019

Thanks

Add a Comment

Login with GitHub to post a comment