Feeling Lucky
?
[#24682] - Correct SQL error when deleting banner tracks on PostgreSQL databases
- Fixed in Code Base
- 22 Apr 2019
- Medium
- Build: staging
- # 24682
- Diff
- richard67:correct-sql-where-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24679 .
Summary of Changes
Correct the initial where clause so it resolves to a boolean true on every kind of SQL database before other conditions are concatenated with " AND ...".
Testing Instructions
See issue #24679 + some testers with MySQL database test if things work like before.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
richard67
- comment
- 22 Apr 2019
Drone failure not related to this PR. Is caused by javascript stuff.
| Labels |
Added:
?
|
||
zero-24
- comment
- 22 Apr 2019
Lets see whether drone gets happy now ;)
richard67
- comment
- 22 Apr 2019
Now drone succeeded, but Travis failed for reasons not related to this PR.
zero-24
- comment
- 22 Apr 2019
Re startet travis https://travis-ci.org/joomla/joomla-cms/builds/523027749
zero-24
- comment
- 22 Apr 2019
CI is happy now merging on review. Thanks.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-22 13:37:02 |
| Closed_By | ⇒ | zero-24 |
richard67
- comment
- 22 Apr 2019
Thanks.
richard67
- comment
- 22 Apr 2019
And thanks to @twister65 who found the mistake.
I have tested this item✅ successfully on 8bdcadb
Successfully tested with PostgreSQL and MySQL databases.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24682.