?

Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
22 Apr 2019

Pull Request for Issue #24679 .

Summary of Changes

Correct the initial where clause so it resolves to a boolean true on every kind of SQL database before other conditions are concatenated with " AND ...".

Testing Instructions

See issue #24679 + some testers with MySQL database test if things work like before.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 22 Apr 2019
avatar richard67 richard67 - change - 22 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category Administration com_banners
avatar twister65
twister65 - comment - 22 Apr 2019

I have tested this item successfully on 8bdcadb

Successfully tested with PostgreSQL and MySQL databases.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24682.

avatar twister65 twister65 - test_item - 22 Apr 2019 - Tested successfully
avatar richard67
richard67 - comment - 22 Apr 2019

Drone failure not related to this PR. Is caused by javascript stuff.

avatar zero-24 zero-24 - change - 22 Apr 2019
Labels Added: ?
avatar zero-24
zero-24 - comment - 22 Apr 2019

Lets see whether drone gets happy now ;)

avatar richard67
richard67 - comment - 22 Apr 2019

@zero-24 Can you also set back the result of twister65's test?

avatar richard67
richard67 - comment - 22 Apr 2019

Now drone succeeded, but Travis failed for reasons not related to this PR.

avatar zero-24
zero-24 - comment - 22 Apr 2019
avatar zero-24
zero-24 - comment - 22 Apr 2019

CI is happy now merging on review. Thanks.

avatar zero-24 zero-24 - close - 22 Apr 2019
avatar zero-24 zero-24 - merge - 22 Apr 2019
avatar zero-24 zero-24 - change - 22 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 13:37:02
Closed_By zero-24
avatar richard67
richard67 - comment - 22 Apr 2019

Thanks.

avatar richard67
richard67 - comment - 22 Apr 2019

And thanks to @twister65 who found the mistake.

Add a Comment

Login with GitHub to post a comment