NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
17 Apr 2019

Summary of Changes

At the moment, if you go to the articles view and select an article, the "Change Status" (and the sub-buttons) button becomes active/disabled depending on the available transitions, but clicking a disable status change does not prevent the execution.
Also multiple possibilities are not recognized anymore (should show a modal).

Reason: there are new event listeners which conflicts with the workflow listener.

Testing Instructions

  • Select an article and click on a disabled dropdown option
    or
  • Select an article and click on a dropdown option with different transitions

Expected result

Warning message or modal to select the correct transition

Actual result

Form will be submitted

avatar bembelimen bembelimen - open - 17 Apr 2019
avatar bembelimen bembelimen - change - 17 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2019
Category JavaScript Repository NPM Change
avatar bembelimen bembelimen - change - 17 Apr 2019
The description was changed
avatar bembelimen bembelimen - edited - 17 Apr 2019
avatar wilsonge wilsonge - change - 17 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-17 13:52:39
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 17 Apr 2019
avatar wilsonge wilsonge - merge - 17 Apr 2019
avatar infograf768
infograf768 - comment - 17 Apr 2019

Imho, not sure this solves the issue.

Test: set an article as Unpublished. All other articles are Published.

Select all articles via checkall button.

Use the Change Status dropdown
Both Unpublished and Published are greyed.
Trying to click on one or the other throws an error

Error
One or more of the selected articles can't be set to unpublished.

Error
One or more of the selected articles can't be set to published.

avatar bembelimen
bembelimen - comment - 17 Apr 2019

Hi @infograf768 yes, you're right, as mentioned here: #24517 (comment) there are several thing got broken the last months, so I have to recover one by one...

avatar infograf768
infograf768 - comment - 17 Apr 2019

OK.

Add a Comment

Login with GitHub to post a comment