? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
17 Apr 2019

Removes a redundant role attribute. These are links and are not acting like buttons

To test ensure the installer keeps functioning

avatar wilsonge wilsonge - open - 17 Apr 2019
avatar wilsonge wilsonge - change - 17 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2019
Category Installation
avatar brianteeman
brianteeman - comment - 17 Apr 2019

I have tested this item successfully on 51ecd73


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24620.

avatar brianteeman brianteeman - test_item - 17 Apr 2019 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 17 Apr 2019

I have tested this item successfully on 51ecd73


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24620.

avatar zwiastunsw zwiastunsw - test_item - 17 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2019

Status "Ready To Commit".

avatar Quy
Quy - comment - 17 Apr 2019

Remove title attributes too? They don't add additional information to the buttons. If yes, I will create a PR for it.

avatar zwiastunsw
zwiastunsw - comment - 17 Apr 2019

@Quy : yes! It's a redundant attribute.

avatar wilsonge wilsonge - change - 17 Apr 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 17 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-17 13:55:04
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Apr 2019
avatar wilsonge wilsonge - merge - 17 Apr 2019
avatar wilsonge
wilsonge - comment - 17 Apr 2019

Thanks!

avatar hardik-codes
hardik-codes - comment - 17 Apr 2019

Remove title attributes too? They don't add additional information to the buttons. If yes, I will create a PR for it.

@Quy may I do a PR for you?

avatar Quy
Quy - comment - 17 Apr 2019

@hardik-codes Go for it. Thanks.

Add a Comment

Login with GitHub to post a comment