User tests: Successful: Unsuccessful:
Pull Request for Issue #20986
replace the custom element for the switcher field with pure css and accessible
it uses a legend to describe the fieldset and the label for the values as normal
Requires npm i
Status | New | ⇒ | Pending |
Category | ⇒ | Layout Libraries |
Labels |
Added:
?
|
I have tested this item
As for the final location for the CSS file, I'd put it into https://github.com/joomla/joomla-cms/tree/4.0-dev/build/media_source/system/css/fields which ends up in /media/system/css/fields after building.
This way it can be overriden by the template if they choose so.
Show radio button checked 1 of 8
Hide radio button checked 4 od 8
instead:
Show radio button checked 1 of 2
Hide radio button checked 2 od 2
When I copy the source code of a page and read it outside the context of the backend (as a separate document), the screen reader correctly reads the label of each switch and its status. (Do not load any js then.)
Firefox test: switches do not receive keyboard focus at all
Can anyone confirm this?
Which exact page. Maybe there is a markup bug somewhere
I "think" I know what the problem is. It's not the code here. But could you please tell me the page you tested so I can confirm
@zwiastunsw I think it could be because the fieldsets are nested inside other fieldsets https://test-cases.tink.uk/nested-fieldsets/index.html
@zwiastunsw if that is the problem then we can use an alternative method instead of fieldset which is to use role=group
I tested Site Modules > Breadcrumbs.
Windows 10, Chrome v. 73.0.3683.86 (64 bit).
@zwiastunsw I am going to have to reach out to some external a11y experts on this. As you discovered the code works perfectly on a plain html page but not within joomla. I cant see anything in joomla that would break it.
Title |
|
@zwiastunsw @wilsonge I found the problem. It is NOT in the code here. The problem is in the tabs code. When you open a module for the first time ALL the sections are set with aria-hidden=true. The first tab should not be
Labels |
Added:
?
Removed: J4 Issue |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
@jeckodevelopment why did you update the branch? It doesn't have any purpose and forces my local branch to be out of date
merge button was not available due to the branch being out of sync
@jeckodevelopment that is only relevant for the person who does the merge . it doesnt need to be done repeatedly. it has no impact on the ability to test the pr as long as there are no conflicts. All it does is waste your time pressing the button and my time updating my local branch
Let's chill :)
Is this now working from a screenreader perspective? @zwiastunsw
I'm chilled
Go for it
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Category | Layout Libraries | ⇒ | Repository NPM Change Layout Libraries |
Labels |
Added:
NPM Resource Changed
?
Removed: ? |
Category | Layout Libraries Repository NPM Change | ⇒ | Administration Templates (admin) Repository NPM Change JavaScript Layout Libraries Front End Templates (site) |
Title |
|
Updated code and original post with test instructions
Labels |
Added:
?
Removed: ? |
The js tests are failing as expected as the js is no longer present. Should I remove the tests in this pr?
Title |
|
Labels |
Added:
?
Removed: ? |
tests removed
Category | Layout Libraries Repository NPM Change Administration Templates (admin) JavaScript Front End Templates (site) | ⇒ | Administration Templates (admin) Repository NPM Change JavaScript Layout Libraries Front End Templates (site) Unit Tests |
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 16:41:59 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
Removed: ? |
Thanks!
Woohoo
I have tested this item✅ successfully on 6f96df0 using Module.
System information
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24463.