[#24464] - [4.0] Changing format handling in Smart Search
- Closed
- 23 Oct 2020
- Medium
- Build: 4.0-dev
- # 24464
- Diff
- Hackwar:j4finder_format
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Smart Search has the ability to parse different formats of data, be it HTML, TXT or RTF. And in theory you could extend that to parse also PDFs or DOCX. Unfortunately, right now you are forced to decide which format the whole result item is in for all properties when calling index() in your finder plugin. This prevents us from having results that contain normal HTML and then maybe a file in PDF and another in DOCX format. It is a bit the Highlander issue...
This PR changes that so that you can set the format of the property when telling the indexer how to index that part.
How to test?
In core Joomla, this should not have any impact at all. So simply run the indexer and/or use finder how you did before and you should not notice a difference. I'm asking however for a codereview on this to make sure that my idea is sane. Thus I'm calling for the powers of @chrisdavenport and @wilsonge
In another PR, I would also like to add the possibility to point to a file path. If we really want to allow indexing of PDF files for example, we have to change the system a bit to not add the whole file to the result object, too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
This will not be part of 4.0. Maybe we can do this for 4.1 or something like that.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-23 19:58:18 |
| Closed_By | ⇒ | Hackwar |
After some more thought, this will need further changes. Please don't merge this yet.