[#24417] - Fix to JFormFieldCalendar using different formats
- Closed
- 14 Apr 2022
- Medium
- Build: staging
- # 24417
- Diff
- Arpit-24:staging-calendar
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21148 .
Summary of Changes
Increased colspan of amp/pm selector to make it visible
Changed $this->format to the fixed format of "%Y-%m-%d %H:%M:%S" fixes the issue as the format is already converted and displayed properly using the calendar.js file so no need to change the format twice.
Testing Instructions
Please refer Issue #21148
Earlier there was a blank field displayed in the input text field after saving while it was correctly saved in the database.
The selection now appears properly :
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript |
When testing, kame sure to test not only with an english language but also with eg german and other languages that have different date/time formats.
| Labels |
Added:
?
|
||
I had a bit time to look into this. The underlying issue is that the PHP strftime function doesn't recognize the %P format and thus results false. Checking the PHP documentation (http://us2.php.net/manual/en/function.strftime.php) it explicitely states that
Not all conversion specifiers may be supported by your C library, in which case they will not be supported by PHP's strftime().
So as I understand it, this depends on the server if %P is supported or not.
However in my test, %p ("AM/PM" instead of "am/pm") worked fine.
I honestly don't think we can do much here. The developer just has to use a format which is supported by the server.
I have tested this item
Only tested in English, but the PR corrects all issues found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24417.
I have tested this item
Only tested in English, but the PR corrects all issues found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24417.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24417.
Please test with different languages. It's clear that it will work with english formats but your test is useless if you don't test with different languages (with and without "translateFormat" active and different hardcoded formats (with and without time, german format, french format, ...)
@billtomczak @viocassel can you please retest as @Bakual mentioned above?
| Labels |
Removed:
J3 Issue
|
||
Can you fix the conflicts please, so we can test it with a none English language and get it merged. Thanks for your work on this bug fix.
I think this user might no longer be active on GitHub, given the PR is 3 years old now.
Sometimes they come back. If not then we need to take some action on this.
Reopening the issue as this pr is abandoned.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-14 05:52:00 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? |
||
@billtomczak @GCLW please Test.