? ? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Mar 2019

rebase of #17709 on 4.0

Summary of Changes

add publish_up, publish_down for (site) menu items

Testing Instructions

see #17709

Documentation Changes Required

?

avatar alikon alikon - open - 30 Mar 2019
avatar alikon alikon - change - 30 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2019
Category SQL Administration com_admin Postgresql com_menus Installation Libraries
247ee34 30 Mar 2019 avatar alikon Text
avatar alikon alikon - change - 30 Mar 2019
Labels Added: ?
5918e22 30 Mar 2019 avatar Quy cs
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2019
Title
[4.0] - Menu items expiration
[4.0] Menu items expiration
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2019
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Mar 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Mar 2019
avatar uglyeoin
uglyeoin - comment - 13 Apr 2019

Happy to test whenever this is ready thanks for all your hard work

avatar Quy
Quy - comment - 13 Apr 2019

@uglyeoin It is ready to be tested.

avatar uglyeoin
uglyeoin - comment - 13 Apr 2019

@uglyeoin It is ready to be tested.

@Quy Awesome, I'll test next week when I have some time. It says it's out of date with the base, should I wait until that is fixed?

avatar infograf768 infograf768 - change - 13 Apr 2019
Labels Removed: J4 Issue
avatar infograf768
infograf768 - comment - 13 Apr 2019

Updating branch

avatar uglyeoin
uglyeoin - comment - 16 Apr 2019

It's out of date again. Should I test anyway @infograf768 or would it mean I need to test again so I should wait?

avatar uglyeoin
uglyeoin - comment - 16 Apr 2019

I have tested this item ? unsuccessfully on 3912488

I used Joomla! 4 and I used Patch Tester to install the patch (which might be the wrong thing to do).

I got this error when I clicked on menus > show all menu items

An error has occurred.
500 Unknown column 'a.publish_up' in 'field list'


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar uglyeoin
uglyeoin - comment - 16 Apr 2019

I have tested this item ? unsuccessfully on 3912488

I used Joomla! 4 and I used Patch Tester to install the patch (which might be the wrong thing to do).

I got this error

An error has occurred.
500 Unknown column 'a.publish_up' in 'field list'


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar uglyeoin uglyeoin - test_item - 16 Apr 2019 - Tested unsuccessfully
avatar wojsmol
wojsmol - comment - 16 Apr 2019

@uglyeoin Branch is out-of-datu but don't have merge conflicts so you can test this.

avatar uglyeoin
uglyeoin - comment - 16 Apr 2019

@wojsmol in which case... it failed the test. It installed the patch correctly so I don't think we can blame patch tester but I really am not experienced enough to know if that's right. It does seem like the error comes from this pull request, hopefully it's something simple.

avatar wojsmol
wojsmol - comment - 16 Apr 2019

@uglyeoin You must fix database after installing the patch using the Patch Tester.

avatar infograf768
infograf768 - comment - 17 Apr 2019

I have tested this item successfully on add4162


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar infograf768
infograf768 - comment - 17 Apr 2019

I have tested this item successfully on add4162


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar infograf768 infograf768 - test_item - 17 Apr 2019 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

image
Probably not the fault of this pull request but tooltip has
which is ignored and shown as literal

avatar Quy
Quy - comment - 17 Apr 2019

@uglyeoin It is a separate issue reported in #21373.

avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

@Quy I don't want to clog up this pull request but I found some other things I'd like to report/suggest. One is for the J4 Template team. Is there some way I can easily find out where to report this stuff? Sorry to ask such a noob question.

avatar Quy
Quy - comment - 17 Apr 2019

Report to the backend template repo: https://github.com/joomla/backend-template/tree/release

avatar infograf768
infograf768 - comment - 17 Apr 2019

We still need another tester here if we want to get this feature in.

avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

I have tested this item successfully on e665b11

The item was shown with the correct icon. After the publish date passed it showed as published on both the front and back end.

After the publish end date had passed it showed as unpublished on both the back and front end.

Everything worked as I expected it to.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

I have tested this item successfully on e665b11

The item was shown with the correct icon. After the publish date passed it showed as published on both the front and back end.

After the publish end date had passed it showed as unpublished on both the back and front end.

Everything worked as I expected it to.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar uglyeoin uglyeoin - test_item - 17 Apr 2019 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

We still need another tester here if we want to get this feature in.

done

avatar infograf768
infograf768 - comment - 17 Apr 2019

@alikon
Shall we RTC this now or you want to quote db stuff first?

avatar alikon
alikon - comment - 17 Apr 2019

it has been around since 3.8.0, so please RTC.....
i re-swear i'll do the quote stuff after land in 4.0 ?

avatar Quy Quy - change - 17 Apr 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Apr 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar Quy
Quy - comment - 17 Apr 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24416.

avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

Yay, thank you @alikon this is an awesome new feature

avatar infograf768 infograf768 - change - 19 Apr 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 22 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 22:25:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Apr 2019
avatar wilsonge wilsonge - merge - 22 Apr 2019
avatar wilsonge
wilsonge - comment - 22 Apr 2019

Thanks. This is a nice feature!

Add a Comment

Login with GitHub to post a comment