Feeling Lucky
?
?
[#24391] - [4.0][com_content featured] Remove redundant intro_image check
- Closed
- 28 Mar 2019
- Medium
- Build: 4.0-dev
- # 24391
- Diff
- ReLater:patch-9
User tests: Successful: Unsuccessful:
Summary of Changes
- Remove lines for check if intro image exists because this is done in JLayout already.
Testing Instructions
Code review in pr plus code of JLayout joomla.content.intro_image https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/content/intro_image.php#L17
Or:
- Create some featured articles with and without intro images.
- Test that nothing has changed after applying the patch. Intro images are displayed or not.
Expected result
- Nothing has changed.
Actual result
- Unnecessary/redundant code.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Quy
- comment
- 28 Mar 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24391.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Mar 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24391.
Quy
- comment
- 28 Mar 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24391.
wilsonge
- comment
- 28 Mar 2019
The 3.x one is RTC so again going to close this one as it will get merged through from the 3.x branch
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-28 14:37:57 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 39fe26f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24391.