Feeling Lucky
?
?
[#24392] - [4.0][JLayout images] Remove unnecessary isset(...)
- Closed
- 28 Mar 2019
- Medium
- Build: 4.0-dev
- # 24392
- Diff
- ReLater:patch-13
User tests: Successful: Unsuccessful:
Testing Instructions
- Code review. We don't need the additional isset(...) check because !empty(...) is sufficient.
Expected result
- No changes with output of intro images in category blogs and featured blogs
- No changes with output of full images in article views
Actual result
- Unnecessary code.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 28 Mar 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24392.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 28 Mar 2019
Status "Ready To Commit".
| Labels |
Added:
?
|
||
wilsonge
- comment
- 28 Mar 2019
This has been merged into the 3.x branch. It will make it upto j4 from there. Going to close this as a result
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-28 14:37:31 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 2bf6911
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24392.