? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
27 Mar 2019

Testing Instructions

  • Code review. We don't need the additional isset(...) check because !empty(...) is sufficient.

Expected result

  • No changes with output of intro images in category blogs and featured blogs
  • No changes with output of full images in article views

Actual result

  • Unnecessary code.
avatar ReLater ReLater - open - 27 Mar 2019
avatar ReLater ReLater - change - 27 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2019
Category Layout
avatar ReLater ReLater - change - 27 Mar 2019
Labels Added: ?
avatar ReLater ReLater - change - 27 Mar 2019
The description was changed
avatar ReLater ReLater - edited - 27 Mar 2019
avatar ReLater ReLater - change - 27 Mar 2019
Title
[3.9][JLayout inro_image] Remove unnecessary isset(...)
[3.9][JLayout images] Remove unnecessary isset(...)
avatar ReLater ReLater - edited - 27 Mar 2019
avatar Quy
Quy - comment - 28 Mar 2019

I have tested this item successfully on 7d9faeb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24390.

avatar Quy Quy - test_item - 28 Mar 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 28 Mar 2019

I have tested this item successfully on 7d9faeb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24390.

avatar SharkyKZ SharkyKZ - test_item - 28 Mar 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Mar 2019

Status "Ready To Commit".

avatar jeckodevelopment jeckodevelopment - change - 28 Mar 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 28 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-28 13:12:49
Closed_By HLeithner
avatar HLeithner HLeithner - close - 28 Mar 2019
avatar HLeithner HLeithner - merge - 28 Mar 2019
avatar HLeithner
HLeithner - comment - 28 Mar 2019

thx

Add a Comment

Login with GitHub to post a comment