Feeling Lucky
?
?
[#24389] - [3.9][com_content featured] Remove redundant intro_image check
- Fixed in Code Base
- 29 Mar 2019
- Medium
- Build: staging
- # 24389
- Diff
- ReLater:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
- Remove lines for check if intro image exists because this is done in JLayout already.
Testing Instructions
Code review in pr plus code of JLayout joomla.content.intro_image https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/intro_image.php#L14
Or:
- Create some featured articles with and without intro images.
- Test that nothing has changed after applying the patch. Intro images are displayed or not.
Expected result
- Nothing has changed.
Actual result
- Unnecessary/redundant code.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Quy
- comment
- 28 Mar 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Mar 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-29 09:51:25 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 29 Mar 2019
thx
I have tested this item✅ successfully on 6a91da1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.