Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24369] - [4.0] Fix modal backdrop overlapping entire page

? Success

User tests: Successful: Unsuccessful:

avatar Arpit-24
Arpit-24
27 Mar 2019

Pull Request for Issue #23636 .

Summary of Changes

Added script to end to relocate the versionsModal to inside the body tag

Testing Instructions

  1. Go to edit articles in administrator panel
  2. Click Versions

Expected result

Modal backdrop at the back of modal

Actual result

Modal backdrop used to cover the entire page earlier

Documentation Changes Required

None

avatar Arpit-24 Arpit-24 - open - 27 Mar 2019
avatar Arpit-24 Arpit-24 - change - 27 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2019
Category ⇒ Administration Templates (admin)
avatar Arpit-24 Arpit-24 - change - 27 Mar 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 8 Jun 2019

I am not sure it should be loaded in index.php.
I tested this below the </form> for each component tmpl/edit.php but I am sure there is a better solution.
Also, I guess the correct js should be something like

<script type="text/javascript">
window.addEventListener('DOMContentLoaded', function() {
	document.body.appendChild(document.getElementById('versionsModal'));
});
</script>

or using

		Factory::getDocument()->addScriptDeclaration(
			<<<JS
window.addEventListener('DOMContentLoaded', function() {
	document.body.appendChild(document.getElementById('versionsModal'));
});
JS
		);

in the display method of the HtmlView.php concerned

avatar infograf768
infograf768 - comment - 9 Jun 2019

I am now proposing a replacement solution for this with a general js loading when necessary.
See #25147

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Jun 2019

Closed as #25147 is merged. @Arpit-24 Thanks for your Work.

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Jun 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-09 09:20:25
Closed_By ⇒ franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 9 Jun 2019

Add a Comment

Login with GitHub to post a comment