Feeling Lucky
?
[#24368] - [4.0] Section setting not respected, misc fixes
- Fixed in Code Base
- 23 Apr 2019
- Medium
- Build: 4.0-dev
- # 24368
- Diff
- SharkyKZ:j4/skipto
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fix section option not being respected.
Remove language autoload.
Move to an earlier event.
Fix codestyle.
Testing Instructions
Test that Site Section setting is respected. E.g. select Administrator (Backend) and try to open skipto menu in frontend by pressing Tab.
Expected result
Skipto menu opens only in selected section.
Actual result
Skipto menu opens everywhere.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Removed:
J4 Issue
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-23 15:22:40 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 23 Apr 2019
Thanks!
The reason that it is running in both sections and ignoring the options is because I was told to change my original code - that worked and is used in the yubikey plugin - by @Quy and @wilsonge #24142 (comment)