[#24362] - [4.0] Fix media field fails in subform
- Closed
- 12 Jan 2020
- Medium
- Build: 4.0-dev
- # 24362
- Diff
- Arpit-24:4.0-media-file
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24179 .
Summary of Changes
Replaced custom open and close functions with bootstrap show and hide functions.
Render iframe in modal body, earlier it wasn't
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change Layout |
| Labels |
Added:
NPM Resource Changed
?
|
||
franz-wohlkoenig
- | Category | Administration Templates (admin) JavaScript Repository NPM Change Layout | ⇒ | Administration JavaScript Layout Repository Templates (admin) |
Thanks for this commit @Arpit-24 very much appreciated.
Regardless of whether there is a patch or not I get this JS error. Nothing happens with the media.
TypeError: this.querySelector(...).open is not a functionjoomla-field-media.js:244:45
I would assume it is not related to this PR, but perhaps you can provide more informatoin.
Could you also address @SharkyKZ point, or ask for clarification if you aren't sure.
Again, thanks for your contribution, you are appreciated.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-12 03:41:18 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) JavaScript Repository Layout | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change Layout |
I don't think you're supposed to use jQuery/Bootstrap here.