? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
26 Mar 2019

Pull Request for an issue raised by @bembelimen

Summary of Changes

Make sure the new_usertype is not hardcoded and in case it does not exists falls back to the guest_usergroup or the static id 1 / public.

Testing Instructions

Clear the default value for new_usertype and check that guest_usergroup or 1 is used.

Expected result

guest_usergroup or 1 is used when new_usertype is not configured

Actual result

fallback is hardcoded

Documentation Changes Required

none

cc @bembelimen @SniperSister @HLeithner

avatar zero-24 zero-24 - open - 26 Mar 2019
avatar zero-24 zero-24 - change - 26 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2019
Category Administration com_users Front End Plugins
avatar zero-24 zero-24 - change - 26 Mar 2019
Labels Added: ?
avatar Quy
Quy - comment - 1 Apr 2019

I have tested this item successfully on 3800d0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363.

avatar Quy Quy - test_item - 1 Apr 2019 - Tested successfully
avatar HLeithner
HLeithner - comment - 2 Apr 2019

We need second test here.

avatar alikon
alikon - comment - 2 Apr 2019

I have tested this item successfully on 3800d0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363.

avatar alikon alikon - test_item - 2 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Apr 2019

Status "Ready To Commit".

avatar HLeithner HLeithner - change - 2 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-02 13:13:38
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 2 Apr 2019
avatar HLeithner HLeithner - merge - 2 Apr 2019
avatar HLeithner
HLeithner - comment - 2 Apr 2019

thx

avatar zero-24
zero-24 - comment - 2 Apr 2019

Thanks. ?

Add a Comment

Login with GitHub to post a comment