[#24350] - [4.0] Fix saving in modal window not working
- Closed
- 24 May 2019
- Medium
- Build: 4.0-dev
- # 24350
- Diff
- Arpit-24:4.0-modal-save-close
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23260 .
Summary of Changes
Retrieving content from iframe is changed. This fixes the issue, and to ensure compatibility across various browsers the || (or) statement was necessary.
Testing Instructions
Install current 4.0-dev with testing sample data.
Go to any menu item of type Category List, Single, Contact, Single Article, Single News Feed
Edit item in modal window
Try save using Save or Save & Close buttons
Expected result
Item saved
Actual result
Fixed Item saved
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I tested after patching with https://issues.joomla.org/tracker/joomla-cms/24349
The or statement is not necessary as contentDocument is supported by all the browsers joomla supports - we dont need to add support for browsers below ie8
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/contentDocument#Browser_compatibility
The or statement is not necessary as contentDocument is supported by all the browsers joomla supports - we dont need to add support for browsers below ie8
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/contentDocument#Browser_compatibility
Updated
I have tested this item
Works after patching with https://issues.joomla.org/tracker/joomla-cms/24349
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24350.
restarted drone
franz-wohlkoenig
- | Category | Administration Templates (admin) JavaScript Repository NPM Change | ⇒ | Administration JavaScript Repository Templates (admin) |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-24 22:06:48 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2019-05-24 22:06:48 | ⇒ | 2019-05-24 22:06:49 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24350
Closing in favor for PR #25001.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24350.
Closing in favor for PR #25001.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24350.
| Category | Administration Templates (admin) JavaScript Repository | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
I have tested this item✅ successfully on 497b22b
Works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24350.