[#24349] - [4.0] Fix to modal not opening on edit button click
- Fixed in Code Base
- 19 May 2019
- Medium
- Build: 4.0-dev
- # 24349
- Diff
- Arpit-24:4.0-modal
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23910 .
Summary of Changes
Added a replacement of " by " in javascript to prevent invalid javascript code of document.getElementById("jform_request_id_id").value from running.
Testing Instructions
Create a menu item of the Single article type
Click button "Edit" for editing selected article.
npm ci is required to compile the js file
Expected result
Modal for edit article opens
Actual result
Didn't happen earlier, happens after this commit.
Documentation Changes Required
None
Results after this commit.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
I have tested this item
Same Behaviour with or without Patch (Patchtester used).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
@franz-wohlkoenig
this pr needs npm ci
this pr needs npm ci
How to know this? Is this by Label "NPM Resource Changed"?
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
I guess so. But it is easy to know also because the file modified is a a js file in the build folder.
build/media_source/legacy/js/bootstrap-init.es5.js
But it is easy to know
this isn't true. Its easier for non-Devs to get Information in Test Instructions that a Pull Request can be tested by Patchtester or npm.
Understand.
I guess we should systematically ask people proposing prs to state that npm is needed.
I'm willing to add a Sentence with Link how to use npm in every opening Thread who need it.
Added npm ci required in the testing instructions.
| Category | Administration Templates (admin) JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change |
| Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository |
| Labels |
Removed:
J4 Issue
|
||
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
@jtester @test Patch applied and works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.
| Labels |
Added:
?
|
||
How to know this? Is this by Label "NPM Resource Changed"?
Yes that's the easiest way
FYI, since this is only a JavaScript change you can use npm run build:js. This is much faster than doing a complete cleanup with npm ci.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-19 06:58:15 |
| Closed_By | ⇒ | roland-d |
I have tested this item✅ successfully on 079cbe4
Good find!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24349.