[#2435] - Update color.php
- Closed
- 10 Nov 2013
- Medium
- Build: master
- # 2435
- Diff
- comproperty247:patch-1
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
At line 43, should be return false; and not return true;
This missed validation only occurs if is not defined a default value and/or is empty
Did that also, thanks anyway
Hi,
Firstly good job :) This seems like a very sensible move
Secondly can you please paste the joomla tracker link into this PR please (it allows us to easily transition between the two - sorry for the hassle).
Thirdly can you also fix the unit test that is broken with this change. It simply involves changing the second parameter on this line: https://github.com/joomla/joomla-cms/blob/master/tests/unit/suites/libraries/joomla/form/rule/JFormRuleColorTest.php#L61 from true to false to match the new expected value.
Thank you very much for your contribution :)
Hi,
As a first time on reporting a bug I really don't know all the "rules"
Here is the joomla tracker link http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32569&start=0
And I just add a PR to fix the unit test as you asked.
Thanks and regards
Not at all :) It's a real pain in the ass so I can completely sympathise! What you've done is perfect (especially when unit test is added). Thankyou very much!
For the future as an fyi - all you need to do on the tracker is link to this PR - no need to upload the php file :)
mbabker
- 
garyamort
-
Please create a tracker on Joomlacode