? Success

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
24 Mar 2019

Pull Request for Issue #23801 .
Opened again as #23844 is not working.

Summary of Changes

Used JS to fix functions of toggle checkboxes. Avoided JQuery as pointed out in #24100 (comment)

Testing Instructions

Template(Styles) -> Menu Assignment -> 'Toggle Selection' buttons

Expected result

Toggle buttons work

Actual result

Toggle buttons work only for 1st element. Also, doesn't work if class/alias name starts with number eg 1author-menu

Documentation Changes Required

None

avatar bahl24 bahl24 - open - 24 Mar 2019
avatar bahl24 bahl24 - change - 24 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Category Administration com_templates
avatar bahl24 bahl24 - change - 24 Mar 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 24 Mar 2019

cannot comment on the code but i can confirm it works

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0]fixed toggle checkboxes
[4.0] fixed toggle checkboxes
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar infograf768 infograf768 - change - 10 Jun 2019
Labels Removed: J4 Issue
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jun 2019

Closed as replaced by #25155. Thanks for Pull Request @bahl24

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Jun 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-06-10 08:19:13
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 10 Jun 2019

Add a Comment

Login with GitHub to post a comment