? Pending

User tests: Successful: Unsuccessful:

avatar Arpit-24
Arpit-24
24 Mar 2019

Pull Request for Issue #24237 .

Summary of Changes

Hides the header and options panel in full screen mode triggered by using view > fullscreen

Testing Instructions

  1. Open an article for editing from the administrator panel.
  2. In the editor use view > fullscreen

Expected result

Full screen editor with no overlap between elements in all screen resolutions

Actual result

Overlapping options panel with the editor element.

Documentation Changes Required

None

avatar Arpit-24 Arpit-24 - open - 24 Mar 2019
avatar Arpit-24 Arpit-24 - change - 24 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Category Administration Templates (admin)
avatar Arpit-24
Arpit-24 - comment - 24 Mar 2019

Screenshot (1228)

Current result after change.

avatar Arpit-24 Arpit-24 - change - 25 Mar 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 25 Mar 2019

Please update the title of this PR and your others to ensure they are meaningful

avatar Arpit-24 Arpit-24 - change - 25 Mar 2019
Title
4.0 dev
[4.0] Fix full screen design editor view in articles
avatar Arpit-24 Arpit-24 - edited - 25 Mar 2019
avatar infograf768 infograf768 - change - 25 Mar 2019
Title
[4.0] Fix full screen design editor view in articles
[4.0] TinyMCE: Fix full screen design editor view in articles
avatar infograf768 infograf768 - edited - 25 Mar 2019
avatar infograf768
infograf768 - comment - 25 Mar 2019

I have tested this item successfully on c64bf2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24334.

avatar infograf768
infograf768 - comment - 25 Mar 2019

I have tested this item successfully on c64bf2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24334.

avatar infograf768 infograf768 - test_item - 25 Mar 2019 - Tested successfully
avatar bembelimen
bembelimen - comment - 25 Mar 2019

Please see #24110 when updating any TinyMce stuff, they will probably become invalid in a few days...

avatar sanderpotjer
sanderpotjer - comment - 5 May 2019

I have tested this item ? unsuccessfully on c64bf2d

With the latest 4.0-dev branch including the TinyMCE 5 this no longer seems to be an issue. Before applying this patch the screen already looks good without the toolbar being visible.

Screenshot 2019-05-05 at 10 20 20

My suggestion is to close this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24334.

avatar sanderpotjer sanderpotjer - test_item - 5 May 2019 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 May 2019

Closed as suggested above.

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-05 08:44:08
Closed_By franz-wohlkoenig
Labels Removed: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - close - 5 May 2019

Add a Comment

Login with GitHub to post a comment