?
avatar joeforjoomla
joeforjoomla
24 Mar 2019

Steps to reproduce the issue

Execute the disconnectedCallback of the toolbar button custom element

Expected result

No js errors in the console

Actual result

Failed to execute 'removeEventListener' on 'EventTarget': 2 arguments required, but only 1 present

The disconnectedCallback function has the following and incomplete call to removeEventListener, it should be either removed or attached to a proper event handler passed in as the second argument:

this.removeEventListener('click');

System information (as much as possible)

Joomla 4 Alpha 8

avatar joeforjoomla joeforjoomla - open - 24 Mar 2019
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Mar 2019
avatar Quy Quy - change - 24 Mar 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-03-24 16:49:23
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 24 Mar 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Mar 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24333

avatar Quy
Quy - comment - 24 Mar 2019

Please test PR #24338


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24333.

avatar joeforjoomla
joeforjoomla - comment - 6 Jun 2019

#24338 works perfectly, no more errors

Add a Comment

Login with GitHub to post a comment