? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
24 Mar 2019

Pull Request for Issue #24292

Summary of Changes

Thanks @Fedik

Testing Instructions

J clean install.
Create a multilingual site using the multilingual sample data module for at least 2 languages.
Make sure SEF is on.
Also install the blog sample data for any admin language or all.
Load frontend and switch languages.

All should now be OK.

Note

I have no idea why the change in the DI for CMSApplication::getInstance in 4.0 vs 3.9 forces to modify Router::PROCESS_DURING to Router::PROCESS_BEFORE but my tests here show that all works fine with that change and the SiteRouter is correctly used.

avatar infograf768 infograf768 - open - 24 Mar 2019
avatar infograf768 infograf768 - change - 24 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Category Front End Plugins
avatar infograf768 infograf768 - change - 24 Mar 2019
The description was changed
avatar infograf768 infograf768 - edited - 24 Mar 2019
avatar Fedik
Fedik - comment - 24 Mar 2019

I made nothing, you maybe have confused the name ?

avatar infograf768
infograf768 - comment - 24 Mar 2019

oops, sorry. Was @SharkyKZ
#24292 (comment)

avatar infograf768
infograf768 - comment - 25 Mar 2019

@Hackwar
as this shows a change in Router, please comment/test.

avatar SharkyKZ
SharkyKZ - comment - 25 Mar 2019

I have tested this item successfully on aa3175e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24332.

avatar SharkyKZ
SharkyKZ - comment - 25 Mar 2019

I have tested this item successfully on aa3175e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24332.

avatar SharkyKZ SharkyKZ - test_item - 25 Mar 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 25 Mar 2019

Just a note, this has been fixed for 4.0 in the past 6f60e13#diff-9a4ee24a09bcef172864692ed05135ca and reappeared with 3.9 merges.

avatar wilsonge wilsonge - change - 25 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-25 09:32:06
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Mar 2019
avatar wilsonge wilsonge - merge - 25 Mar 2019
avatar wilsonge
wilsonge - comment - 25 Mar 2019

Thanks for checking @SharkyKZ - jogs my memory about this one :)

Thanks for spending the time debugging JM!

avatar infograf768
infograf768 - comment - 25 Mar 2019

I am still curious to why the change in 4.0 vs 3.9. Could someone explain to me (and all)?

avatar infograf768
infograf768 - comment - 25 Mar 2019

Also, out of curiosity, I modified the language filter in 3.x to use $router->attachParseRule(array($this, 'parseRule'), JRouter::PROCESS_BEFORE); instead of DURING
and guess what? It works fine...

avatar Chacapamac
Chacapamac - comment - 26 Mar 2019

Work for me.

Add a Comment

Login with GitHub to post a comment