? Success

User tests: Successful: Unsuccessful:

avatar Arpit-24
Arpit-24
24 Mar 2019

Pull Request for Issue #24114 .

Summary of Changes

Overflow is made visible for the ul element wrapping the datepicker

Testing Instructions

go to administrator=>content=>articles=>new=>publish tab
set width of tab less than 920 pixel
open the first calender

Expected result

Full Accessible Calender

Actual result

Partially accessible calender is now fixed

Documentation Changes Required

None

Screenshot (1229)

After this change

avatar Arpit-24 Arpit-24 - open - 24 Mar 2019
avatar Arpit-24 Arpit-24 - change - 24 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2019
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 25 Mar 2019
Title
Fix Issue #24114
[4.0] Fix Issue #24114
avatar infograf768 infograf768 - edited - 25 Mar 2019
avatar infograf768
infograf768 - comment - 25 Mar 2019

Not sure I understand this patch

.mce-fullscreen
is specific to TinyMCE and, if necessary, should be added in atum/scss/vendor/_tinymce.scss

Overflow is made visible for the ul element wrapping the datepicker

As far as I know, the calendar has a <div> container, not a <ul>

can you explain better?

avatar infograf768
infograf768 - comment - 25 Mar 2019

concerning the mce-fullscreen it looks like some mixup with #24334

avatar Arpit-24 Arpit-24 - change - 25 Mar 2019
Labels Added: ?
avatar Arpit-24
Arpit-24 - comment - 25 Mar 2019

concerning the mce-fullscreen it looks like some mixup with #24334

Yes, It was a mix with another issue fix. Apologies for the mistake.

And regarding why making overflow visible fixes the issue is. In the joomla-custom-elements.
The style for joomla-tab > ul is set to overflow-y:hidden which causes it to hide elements that exceed its bound.

In lower screen sizes the date picker element the div itself is going out of the size defined by ul element for its children thus causing it to be hidden.

avatar Arpit-24 Arpit-24 - change - 25 Mar 2019
Title
[4.0] Fix Issue #24114
[4.0] Fix Issue of inaccessible calendar in articles if width is small
avatar Arpit-24 Arpit-24 - edited - 25 Mar 2019
avatar infograf768
infograf768 - comment - 25 Mar 2019

This is not working here:
Screen Shot 2019-03-25 at 10 13 40

avatar C-Lodder
C-Lodder - comment - 25 Mar 2019

The calendar z-index also needs changing.

Please don't add your code to the template.scss. This file is supposed to be used as the base for importing all sub-scss files

avatar Arpit-24
Arpit-24 - comment - 25 Mar 2019

The calendar z-index also needs changing.

Please don't add your code to the template.scss. This file is supposed to be used as the base for importing all sub-scss files

Updated the commit to _form.scss file

avatar Arpit-24
Arpit-24 - comment - 25 Mar 2019

This is not working here:
Screen Shot 2019-03-25 at 10 13 40

I was unable to replicate the issue. Could you give me some more details? It seems fixed for me.

My Configuration :
Windows 10 x64
Google Chrome Version 73.0.3683.86

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Mar 2019

@Puneet-Jain-18 please test.

avatar infograf768
infograf768 - comment - 27 Mar 2019

I have tested this item successfully on b15ad3c

I tested the display of the calendar and it is now OK.

Remains an issue here when the window is small enough forces scroll bars to display (Firefox)
In that case we may need to scroll to see the calendar fully, BUT clicking on the scroll bars closes the calendar.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar infograf768 infograf768 - test_item - 27 Mar 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 27 Mar 2019

scollbars_calendar

avatar Arpit-24
Arpit-24 - comment - 3 Apr 2019

Remains an issue here when the window is small enough forces scroll bars to display (Firefox)
In that case we may need to scroll to see the calendar fully, BUT clicking on the scroll bars closes the calendar.

Eliminated the need for horizontal scrolling. For vertical scrolling in mobiles if we scroll normally using touch then it doesn't close as emulated by chrome, but yes clicking the scrollbar will close it as is the expected browser behavior of taking the focus away from all the elements and giving the focus to body tag, and loosing focus from the input field will close the calendar picker.

avatar C-Lodder
C-Lodder - comment - 4 Apr 2019

I mean a SCSS variable (should already be defined), not CSS variables

avatar Arpit-24
Arpit-24 - comment - 4 Apr 2019

I mean a SCSS variable (should already be defined), not CSS variables

Unfortunately, I couldn't find an already defined scss variable to use in the _variables.scss file. created a new one for use.

avatar C-Lodder
C-Lodder - comment - 4 Apr 2019

We use the following breakpoints:

$grid-breakpoints: (
  xs: 0,
  sm: 576px,
  md: 768px,
  lg: 992px,
  xl: 1200px
);

So you'll want to use:

@include media-breakpoint-down(sm) {
  .js-calendar {
    right: 0;
  }
}
avatar Arpit-24
Arpit-24 - comment - 4 Apr 2019

We use the following breakpoints:

$grid-breakpoints: (
  xs: 0,
  sm: 576px,
  md: 768px,
  lg: 992px,
  xl: 1200px
);

So you'll want to use:

@include media-breakpoint-down(sm) {
  .js-calendar {
    right: 0;
  }
}

Updated

avatar Puneet-Jain-18
Puneet-Jain-18 - comment - 19 Apr 2019

I have tested this item successfully on e8acf35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar Puneet-Jain-18 Puneet-Jain-18 - test_item - 19 Apr 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2019

@infograf768 please retest

avatar infograf768 infograf768 - change - 20 Apr 2019
Labels Removed: J4 Issue
avatar tushar33 tushar33 - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar tushar33
tushar33 - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on 4fd3b6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar tushar33 tushar33 - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar tushar33
tushar33 - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on 4fd3b6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar yasin-96 yasin-96 - test_item - 3 Aug 2020 - Tested successfully
avatar yasin-96
yasin-96 - comment - 3 Aug 2020

I have tested this item successfully on 4fd3b6c

After following the testing instructions I can confirm that the calender is full accessible.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar johndeutesfeld johndeutesfeld - test_item - 3 Aug 2020 - Tested successfully
avatar johndeutesfeld
johndeutesfeld - comment - 3 Aug 2020

I have tested this item successfully on 4fd3b6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar alikon alikon - change - 3 Aug 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 3 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar roland-d roland-d - alter_testresult - 4 Aug 2020 - tushar33: Not tested
avatar roland-d roland-d - alter_testresult - 4 Aug 2020 - tushar33: Not tested
avatar roland-d
roland-d - comment - 4 Aug 2020

@Arpit-24 While checking this issue I think the problem is already fixed without your changes. Can you check?

This is what I see without your changes:
image

avatar roland-d
roland-d - comment - 4 Aug 2020

@Arpit-24 Never mind, I see the issue in fullscreen mode.

avatar roland-d
roland-d - comment - 4 Aug 2020

@Arpit-24 Must have been cache because I cannot reproduce the issue again. So can you check if your change is still necessary?

avatar infograf768
infograf768 - comment - 4 Aug 2020

I agree with @roland-d
I cannot reproduce the issue here in 4.0-dev

taking off rtc

avatar infograf768 infograf768 - change - 4 Aug 2020
Status Ready to Commit Discussion
avatar infograf768
infograf768 - comment - 4 Aug 2020

Moving to discussion


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24336.

avatar infograf768
infograf768 - comment - 4 Aug 2020

In fact calendar.js has been modified since April 2019.
I guess this can be closed.

avatar roland-d
roland-d - comment - 4 Aug 2020

@Arpit-24 Thank you for your contribution, if this issue still exists, feel free re-open the issue and we can check again.

avatar roland-d roland-d - change - 4 Aug 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-08-04 06:26:13
Closed_By roland-d
avatar roland-d roland-d - close - 4 Aug 2020
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2020
Category Administration Templates (admin) Administration Templates (admin) NPM Change

Add a Comment

Login with GitHub to post a comment