User tests: Successful: Unsuccessful:
Pull Request for Issue #24114 .
Overflow is made visible for the ul element wrapping the datepicker
go to administrator=>content=>articles=>new=>publish tab
set width of tab less than 920 pixel
open the first calender
Full Accessible Calender
Partially accessible calender is now fixed
None
After this change
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Title |
|
Labels |
Added:
?
|
concerning the
mce-fullscreen
it looks like some mixup with #24334
Yes, It was a mix with another issue fix. Apologies for the mistake.
And regarding why making overflow visible fixes the issue is. In the joomla-custom-elements.
The style for joomla-tab > ul is set to overflow-y:hidden which causes it to hide elements that exceed its bound.
In lower screen sizes the date picker element the div itself is going out of the size defined by ul element for its children thus causing it to be hidden.
Title |
|
The calendar z-index also needs changing.
Please don't add your code to the template.scss
. This file is supposed to be used as the base for importing all sub-scss files
The calendar z-index also needs changing.
Please don't add your code to the
template.scss
. This file is supposed to be used as the base for importing all sub-scss files
Updated the commit to _form.scss file
@Puneet-Jain-18 please test.
I have tested this item
I tested the display of the calendar and it is now OK.
Remains an issue here when the window is small enough forces scroll bars to display (Firefox)
In that case we may need to scroll to see the calendar fully, BUT clicking on the scroll bars closes the calendar.
Remains an issue here when the window is small enough forces scroll bars to display (Firefox)
In that case we may need to scroll to see the calendar fully, BUT clicking on the scroll bars closes the calendar.
Eliminated the need for horizontal scrolling. For vertical scrolling in mobiles if we scroll normally using touch then it doesn't close as emulated by chrome, but yes clicking the scrollbar will close it as is the expected browser behavior of taking the focus away from all the elements and giving the focus to body tag, and loosing focus from the input field will close the calendar picker.
I mean a SCSS variable (should already be defined), not CSS variables
I mean a SCSS variable (should already be defined), not CSS variables
Unfortunately, I couldn't find an already defined scss variable to use in the _variables.scss file. created a new one for use.
We use the following breakpoints:
$grid-breakpoints: (
xs: 0,
sm: 576px,
md: 768px,
lg: 992px,
xl: 1200px
);
So you'll want to use:
@include media-breakpoint-down(sm) {
.js-calendar {
right: 0;
}
}
We use the following breakpoints:
$grid-breakpoints: ( xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px );
So you'll want to use:
@include media-breakpoint-down(sm) { .js-calendar { right: 0; } }
Updated
I have tested this item
@infograf768 please retest
Labels |
Removed:
J4 Issue
|
I have tested this item
I have tested this item
I have tested this item
After following the testing instructions I can confirm that the calender is full accessible.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Discussion |
Moving to discussion
In fact calendar.js has been modified since April 2019.
I guess this can be closed.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 06:26:13 |
Closed_By | ⇒ | roland-d |
Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) NPM Change |
Not sure I understand this patch
.mce-fullscreen
is specific to TinyMCE and, if necessary, should be added in
atum/scss/vendor/_tinymce.scss
As far as I know, the calendar has a
<div>
container, not a<ul>
can you explain better?