[#24328] - [4.0] Enable button when returning from article
- Closed
- 27 Aug 2020
- Medium
- Build: 4.0-dev
- # 24328
- Diff
- maliouris:4branch
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 2 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fix disabled buttons to enabled when an element is already selected on load.
Testing Instructions
Steps to reproduce the issue. Go to articles, select an article and then press the name of it to edit it. Press the back button to go back and you will see that the buttons change status and batch are disabled and cant be enabled even if you deselect it and then you select it again.
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository |
@franz-wohlkoenig The PR is working as expected, what could be possible reason for the failure of continuous-integration/drone/pr test ??
@Puneet-Jain-18 maybe @rdeutz can help (i'm user, no Developer).
| Labels |
Removed:
J4 Issue
|
||
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
I have tested this item
works as advertised
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
I have tested this item
I was unable to reproduce this. What I did was:
- Check the checkbox
- Click on the name of the article to edit it
- Click on the browser back button
- I get back to the list and the item is not selected anymore
This is using Firefox on Mac.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
@maliouris Thank you for the pull request unfortunately I am unable to reproduce this. Can you check on the current 4.0-dev branch to see if you still have this issue?
Confirmed. OK in Firefox, but not in Chrome.
Click the checkbox next to the article.
Click on the article name to edit.
Click the Back button.
I use chrome and it works for me how is that possible ? However I made that pull request way too long ago so it might not work now because some of the files that I have changed have been updated since my pull request. I don't know and at the moment I cant find out why it doesn't work as it used to do. I mean I don't have the time to do it. I will give it a try after 2 weeks
Removing RTC for now until issue can reliably be reproduced and tested.
| Status | Ready to Commit | ⇒ | Pending |
Status back on "Pending".
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
No files were present while applying patch.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
I have tested this item
1. Tested as instructed
2. Problem still occurs
Edit: using Chrome
When coming back from the edit window the buttons are still disabled. After de-selecting everything via the the top box and re-selecting the article the buttons are active again but I don't think this is the desired change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
I have tested this item
Tested unsuccessfully!
No improvements detected!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-27 18:39:11 |
| Closed_By | ⇒ | Quy |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-08-27 18:39:11 | ⇒ | |
| Closed_By | Quy | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-27 21:52:48 |
| Closed_By | ⇒ | Quy |
Please use spaces instead of tabs...