Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24329] - [4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …)

? Failure

User tests: Successful: Unsuccessful:

avatar nhusung
nhusung
23 Mar 2019

Summary of Changes

Since the introduction of the CategoryEdit form field in the edit models/views of com_content, com_contact, com_newsfeeds and com_banners (d6673d7), there is no action attribute on the catid form field and thus no need to set it anymore.

Testing Instructions

As the changes are pretty small, a code review should be enough. However you can have a look at the category field inside the edit forms of com_content, com_contact, com_newsfeeds and com_banners with users associated to different groups and access levels and privileges.

Expected result

Same as before this pull

avatar nhusung nhusung - open - 23 Mar 2019
avatar nhusung nhusung - change - 23 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2019
Category ⇒ Administration com_banners com_contact com_content com_newsfeeds
avatar nhusung nhusung - change - 23 Mar 2019
The description was changed
avatar nhusung nhusung - edited - 23 Mar 2019
avatar nhusung nhusung - change - 24 Mar 2019
Labels Added: ?
avatar nhusung nhusung - change - 5 Apr 2019
Title
…
[4.0] Remove setFieldAttribute `action` on `catid` in com_content, …
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …) in com_content, com_banners, com_contact, com_newsfeeds
avatar nhusung nhusung - change - 5 Apr 2019
Title
…
[4.0] Remove setFieldAttribute `action` on `catid` in com_content, …
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …) in com_content, com_banners, com_contact, com_newsfeeds
avatar nhusung nhusung - edited - 5 Apr 2019
avatar nhusung nhusung - change - 5 Apr 2019
Title
…
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …) in com_content, com_banners, com_contact, com_newsfeeds
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …)
avatar nhusung nhusung - change - 5 Apr 2019
Title
…
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …) in com_content, com_banners, com_contact, com_newsfeeds
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …)
avatar nhusung nhusung - edited - 5 Apr 2019
avatar SharkyKZ
SharkyKZ - comment - 4 Jul 2019

@nhusung Can you fix the conflict please.

avatar SharkyKZ SharkyKZ - test_item - 4 Jul 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 4 Jul 2019

I have tested this item ✅ successfully on cca35fa

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24329.

avatar SharkyKZ
SharkyKZ - comment - 4 Jul 2019

I have tested this item ✅ successfully on cca35fa

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24329.

avatar SharkyKZ
SharkyKZ - comment - 5 Jul 2019

There are conflicts again ? .

avatar nhusung nhusung - change - 6 Jul 2019
Labels Added: Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2019
Category Administration com_banners com_contact com_content com_newsfeeds ⇒ Administration com_admin com_banners com_contact com_content com_fields com_finder com_menus com_newsfeeds com_templates com_users Language & Strings Modules JavaScript Repository NPM Change Front End External Library Composer Change Layout Libraries
avatar nhusung
nhusung - comment - 6 Jul 2019

Sorry, I made a mistake during the merge

avatar nhusung nhusung - change - 6 Jul 2019
Labels Added: ? ? NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2019
Category Administration com_banners com_contact com_content com_newsfeeds com_admin com_fields com_finder com_menus com_templates com_users Language & Strings Modules JavaScript Repository NPM Change Front End External Library Composer Change Layout Libraries ⇒ Administration com_banners com_contact com_content com_newsfeeds
avatar nhusung nhusung - change - 6 Jul 2019
Labels Removed: ? ? NPM Resource Changed
avatar nhusung
nhusung - comment - 6 Jul 2019

Now my problem should be fixed, sorry again. However, the first push added some review requests and I couldn‘t find a way to remove these. I hope I‘m not getting on your nerves …

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Jul 2019

@nhusung thanks for Contributing, no reason for care about nerves :-)

avatar SharkyKZ SharkyKZ - test_item - 6 Jul 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 6 Jul 2019

I have tested this item ✅ successfully on 28ea0f7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24329.

avatar nhusung nhusung - change - 14 Aug 2019
Labels Removed: Conflicting Files
avatar wilsonge wilsonge - change - 9 Feb 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-02-09 17:03:53
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 9 Feb 2020
avatar wilsonge wilsonge - merge - 9 Feb 2020
avatar wilsonge
wilsonge - comment - 9 Feb 2020

Thanks!

Add a Comment

Login with GitHub to post a comment