Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24279] - [4.0] Fix the structure to meet the schema

NPM Resource Changed ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
21 Mar 2019

Fixes small parts of the schema to match the definition at joomla/schemas#4

I believe making the assets a list rather than an object is fine - because the keys are unused by the code and the demo code in the php actually already has it as a list (see https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/WebAsset/WebAssetRegistry.php#L32)

Json schema allows validation of this https://json-schema.org/understanding-json-schema/ and some IDE's (e.g. PHPStorm) will automatically validate when they see the $schema property in the file and alert developers of any issues

TODO: Before Merging

avatar wilsonge wilsonge - open - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Category ⇒ Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site)
avatar wilsonge wilsonge - change - 21 Mar 2019
Title
…
Fix the structure to meet the schema
[4.0] Fix the structure to meet the schema
avatar wilsonge wilsonge - change - 21 Mar 2019
Title
…
Fix the structure to meet the schema
[4.0] Fix the structure to meet the schema
avatar wilsonge wilsonge - edited - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
The description was changed
avatar wilsonge wilsonge - edited - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
The description was changed
avatar wilsonge wilsonge - edited - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - change - 21 Mar 2019
The description was changed
avatar wilsonge wilsonge - edited - 21 Mar 2019
avatar Fedik
Fedik - comment - 21 Mar 2019

looks good to me ?

avatar wilsonge wilsonge - change - 22 Mar 2019
The description was changed
avatar wilsonge wilsonge - edited - 22 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site) ⇒ Administration Front End JavaScript Repository Templates (admin) Templates (site)
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2019
Category Administration Templates (admin) JavaScript Repository Front End Templates (site) ⇒ Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site)
avatar wilsonge wilsonge - change - 28 Jul 2019
The description was changed
avatar wilsonge wilsonge - edited - 28 Jul 2019
avatar wilsonge wilsonge - change - 28 Jul 2019
The description was changed
avatar wilsonge wilsonge - edited - 28 Jul 2019
avatar wilsonge
wilsonge - comment - 28 Jul 2019

Created a job that automatically publishes the schemas repo to developer.joomla.org and changed our definitions to point at that cleaner URL. Updated the docs too so merging this

avatar wilsonge wilsonge - change - 28 Jul 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-07-28 01:23:13
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 28 Jul 2019
avatar wilsonge wilsonge - merge - 28 Jul 2019

Add a Comment

Login with GitHub to post a comment