? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Mar 2019

The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it.

It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice.

This PR removes the redundant title attribute where the same text is already present from the admin stats module.
This PR removes the title attribute "Go" from the search button, if enabled, of the site smart search module as it is redundant. The language string is also removed.

avatar brianteeman brianteeman - open - 21 Mar 2019
avatar brianteeman brianteeman - change - 21 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Category Modules Administration Language & Strings Front End NPM Change
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Looks good to me - can you revert the package lock changes though please

avatar brianteeman
brianteeman - comment - 21 Mar 2019

oops

avatar brianteeman brianteeman - change - 21 Mar 2019
Labels Added: ? NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Category Modules Administration Language & Strings Front End NPM Change Modules Administration Language & Strings Front End
avatar brianteeman brianteeman - change - 21 Mar 2019
Labels Removed: NPM Resource Changed
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Overriding system test fails as drone appears to have broken. Merging on review

avatar wilsonge wilsonge - change - 21 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-21 12:45:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019
avatar brianteeman
brianteeman - comment - 21 Mar 2019

thanks

Add a Comment

Login with GitHub to post a comment