[#24098] - [4.0] fix the page break tabs view
- Fixed in Code Base
- 15 Mar 2019
- Medium
- Build: 4.0-dev
- # 24098
- Diff
- dgrammatiko:4.0-dev-plg_pageBreak
User tests: Successful: Unsuccessful:
Pull Request for Issue #23965 .
Summary of Changes
Someone removed the / from the <hr> element and thus broke the plugin...
Testing Instructions
Follow the description on the issue
Expected result
Actual result
No tabs!
Documentation Changes Required
No, bug fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Administration com_plugins Front End Plugins |
Should it not be done in a different PR?
Actually that was the issue this PR was supposed to fix. I misread the description of the issue and solved another problem. Then I checked again the issue and solved the initial issue. I'm happy if you can take the code and make 2 PRs out of this...
I have tested this item
Does as it says. Click on the Show full description ... link and with patch you are taken to the Description tag, without patch it just stays on the Plugin tab and does not change to the description tab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24098.
I have tested this item
Does as it says. Click on the Show full description ... link and with patch you are taken to the Description tag, without patch it just stays on the Plugin tab and does not change to the description tab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24098.
I have tested this item
Description in PR #23965 is more accurate and what I tested against.
'Show description' link did nothing before patch, although I could see the tab and click on it. After patch, 'Show hescription' link sent me to description tab as one would expect.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24098.
I have tested this item
Description in PR #23965 is more accurate and what I tested against.
'Show description' link did nothing before patch, although I could see the tab and click on it. After patch, 'Show hescription' link sent me to description tab as one would expect.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24098.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-15 13:44:49 |
| Closed_By | ⇒ | wilsonge |
Thanks!
You are also modifying module long description.
Should it not be done in a different PR?