Joomla! Issue Tracker | Joomla! CMS #24097 - [4.0] Namespacing Finder Indexer classes

Fixed in Code Base
20 Apr 2019
Medium
Build: 4.0-dev
# 24097
Diff
Hackwar:j4search_namespace

Success

Success Hound No violations found. Woof! Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success continuous-integration/drone/pr the build was successful Details

User tests: Successful: Unsuccessful:

Hackwar
5 Mar 2019

This namespaces the Indexer classes of Finder/Smart Search. Besides namespacing, this fixes a few issues where variables were not correctly defined. For B/C, I've added empty files for the old classes, since quite a few finder plugins out there require_once these files.

Hackwar - open - 5 Mar 2019

Hackwar - change - 5 Mar 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 5 Mar 2019

Category

⇒

Administration com_finder

Hackwar - comment - 5 Mar 2019

I'm open for suggestions for the language classnames.

Hackwar - change - 15 Mar 2019

Labels

Added: ?

Hackwar - comment - 15 Mar 2019

I've renamed them to first letter uppercase now.

chmst - comment - 1 Apr 2019

I have tested this with some use cases and it looks good to me. Everything was as expected.
But to say the truth, I did not inspect every line of code and nobody can test all possible constellations.
Maybe it is the best to merge this and then fix what might follow.

94a080b 19 Apr 2019

Moving Finder Indexer files to new location

000279d 19 Apr 2019

Updating Finder code to use namespaced classes for Indexer

Hackwar - change - 19 Apr 2019

Labels

Removed: J4 Issue

Hackwar - comment - 19 Apr 2019

@wilsonge asked me to commit this again to prevent future merge conflicts. I moved the files first and then did changes to the content. Hopefully that should allow git to understand the changes better. The changes are the same as before.

c0a8e63 20 Apr 2019