Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24099] - [4.0] fix the status dropdown arrow colour

? Success

User tests: Successful: Unsuccessful:

avatar Harshil99
Harshil99
5 Mar 2019

Pull Request for Issue #23793 .

Summary of Changes

Changed the background (which is arrows) of both success and danger custom select.

Testing Instructions

Do these changes and then compile with npm ci.

Expected result

Dropdown arrows have grey colour in enabled and disabled state.

Actual result

Color changed to white.

Documentation Changes Required

No

avatar Harshil99 Harshil99 - open - 5 Mar 2019
avatar Harshil99 Harshil99 - change - 5 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2019
Category ⇒ Administration Templates (admin)
avatar C-Lodder
C-Lodder - comment - 5 Mar 2019

Please don't just whack SCSS into the general template.scss file. Use the appropriate files. If you can't be bothered to search, just generate a source map using the build tools.

In this case, use this file: administrator/templates/atum/scss/vendor/bootstrap/_custom-forms.scss

avatar Harshil99
Harshil99 - comment - 5 Mar 2019

Sorry for that. I will update the PR with changes.

avatar Harshil99 Harshil99 - change - 5 Mar 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 6 Mar 2019

Works fine. Will test OK when lines aligned.

avatar Harshil99
Harshil99 - comment - 6 Mar 2019

@infograf768 I have aligned that line to below lines.

avatar infograf768 infograf768 - test_item - 7 Mar 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 7 Mar 2019

I have tested this item ✅ successfully on 70539cf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24099.

avatar infograf768
infograf768 - comment - 7 Mar 2019

I have tested this item ✅ successfully on 70539cf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24099.

avatar Harshil99
Harshil99 - comment - 2 Apr 2019

@infograf768 Still any changes required ?

avatar roland-d
roland-d - comment - 31 Aug 2019

@Harshil99 Can you please fix the merge conflict so I can get this tested?

avatar brianteeman
brianteeman - comment - 31 Aug 2019

@roland-d with the new template this PR is not needed and should be closed

avatar Quy Quy - close - 1 Sep 2019
avatar Quy Quy - change - 1 Sep 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-09-01 00:50:25
Closed_By ⇒ Quy

Add a Comment

Login with GitHub to post a comment