[#24044] - [4.0] Bring the Tests Back Home
- Fixed in Code Base
- 10 Mar 2019
- Medium
- Build: 4.0-dev
- # 24044
- Diff
- dgrammatiko:4.0-dev-JS-tests
User tests: Successful: Unsuccessful:
This PR just bings back the javascript tests
Pull Request for Issue # .
Summary of Changes
- Tests are back in the main repo
npm testruns the tests locally
Testing Instructions
npm teststill performs the js tests { runnpm installbefore!!!, deps have changed!!}
Documentation Changes Required
This needs some adjustments in the drone files. Pinging @rdeutz here as we already discussed the idea of utilising Sauce Labs joomla/test-javascript#11
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change Unit Tests Repository JavaScript |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
Please bring back an updated package.lock file. Otherwise this looks good. Please also see @dneukirchen s PR for the unittests and how he described the tests in the Readme.md.
You can't delete the package lock. sorry!
I wasn't deleting that file, it just removed a lot of lines due to the fact that we removed on dependency...
The .lock is still there
LGTM will wait for a testing team member to actually do the merge
I have tested this item
Finally, node works ie Terminal found karma.conf.js.
Tks.
Docs should be updated too.
Like this one : https://docs.joomla.org/JavaScript_Tests_for_Joomla4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24044.
I have tested this item
Finally, node works ie Terminal found karma.conf.js.
Tks.
Docs should be updated too.
Like this one : https://docs.joomla.org/JavaScript_Tests_for_Joomla4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24044.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24044.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-10 14:48:00 |
| Closed_By | ⇒ | rdeutz |
You can't delete the package lock. sorry!