? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
28 Feb 2019

Summary of Changes

This PR corrects the rtl display of the media manager.
Plus:
It also modifies 2 language strings (dates) and allows Jalali date to be displayed.
It adds a missing lang string.
It adds to the frontend com_media.ini the missing lang strings to let create site only lang packs.
It orders language strings in the ini files as well as in default_texts.php

What it does not do:
It does not delete the frontend language strings which are no more used.
It does not solve the frontend infobar absent display.
It does not solve frontend Inserting image in article TypeError: Joomla.getImage is not a function

Testing Instructions

Install the Persian Language pack (administrator/index.php?option=com_installer&view=languages)
Switch to Persian in administrator.
Display the media manager.

Patch and run npm ci

Before patch

This is what we get for LTR

screen shot 2019-02-28 at 08 23 57ltr

This is what we get for RTL

screen shot 2019-02-28 at 08 19 20rtlbefore

After patch

This is what we should get for RTL

screen shot 2019-02-28 at 12 09 33

Supplementary test

After patch and npm ci
Enable Debug lang.
Delete or change name of administrator/language/en-GB/en-GB.com_media.ini in order to load ONLY the front end file.
Edit an article in front end and display the xtd Images modal
There should not be any more untranslated strings

Documentation Changes Required

None

avatar infograf768 infograf768 - open - 28 Feb 2019
avatar infograf768 infograf768 - change - 28 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2019
Category Administration com_media NPM Change Language & Strings Front End Plugins
avatar infograf768 infograf768 - change - 28 Feb 2019
Labels Added: ? NPM Resource Changed ?
ff2a98e 28 Feb 2019 avatar infograf768 oops
avatar infograf768 infograf768 - change - 28 Feb 2019
The description was changed
avatar infograf768 infograf768 - edited - 28 Feb 2019
avatar wilsonge wilsonge - change - 28 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-28 13:26:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Feb 2019
avatar wilsonge wilsonge - merge - 28 Feb 2019
avatar wilsonge
wilsonge - comment - 28 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment