Please alpha sort the language file and check to see if we need the _DESC - most of those are completely unnecessary and we have in general removed all _DESC from J4

Fixed the language string. The DESC string is maybe not necessary, but it is still used everywhere (100+ results if you search for it) so if you want to remove those, please do that consistently in another PR.

@Hackwar It has already been done. The only _DESC strings that remain are the few that we are still displaying and the _DESC strings that are for DESCENDING not DESCRIPTION

No, it hasn't been done, because these strings are fresh from the backend menu items of com_content.

https://github.com/joomla/joomla-cms/pull/24020/files#diff-1cea33e0f389319a3d2adc85965a3e72R5

There are currently 40 default.xml files with a DESC string in them in /administrator/components, excluding the 4 that I've added in this PR. As I said, if that is not wanted/allowed anymore, then please open a PR that removes all these.

Sorry I didnt realise they were for the menu descriptions. Those are being kept - its the _desc that were used as tooltips that have gone .

/me needs coffee

I have tested this item ? unsuccessfully on 544ace4

Followed test instructions but didnt get a sub menu

I have tested this item ✅ successfully on 8ac7581

tested OK on a clean install

@Hackwar
Also please solve conflicts.

I can't see the error that I have in the postgres SQL file. Could someone have a look here?

Tests have passed now.

I have tested this item ✅ successfully on e525eb7

OK with new install.
No submenus when updating using Patchtester, but it might be an issue with Patchtester. Manually ran update SQL successfully.

I have tested this item ✅ successfully on e525eb7

Tested successfully with new installation.

RTC

RTC

@franz-wohlkoenig please removed RTC for now
@Hackwar can you please address the two comments from @Quy

Thanks

done

Database fix will not find the updates as they have an old date. Changing the date to current should resolve that

There is a copy paste error in the sql. You have not updated the "class:associations"

From looking at others this should be "class:finder", "class:finder-maps" etc

Also I'm not sure what the best practice is but the update sql does not have the lft/rght values

Can you look at resolving the conflicts so that this can be tested please.

@brianteeman Your comment above about database fixer and file names is wrong. Database fix will not do anything with the schema updates, because they contain only DML (data manipulation language like INSERT, UPDATE, DELETE). The database fixed only handles DDL (data definition language like CREATE TABLE, ALTER TABLE, DROP TABLE). This does not depend on the file name. The file name is only relevant for version compare when updating, so the installer runs only schema updates with version newer than schema version in database before the update.

@Hackwar You should update your testing instructions accordingly. Fix button does not make sense. Schema updates have to be applied e.g. in PhpMyAdmin or PhpPgAdmin or so.

@richard67 the file name means that the database fix wont even see the update. Whether it works or not is a different issue.

@brianteeman You are wrong. The database fixer always checks all available schema update files, if there are some from 2.5 it will be checked, too, even when being on a 3.9.10. It is the installer/updater where the file name is relevant. I always wanted to change that, but it would be a bigger development changing the weak points of the database fix, and so I haven't made it yet. But of course you are right with the file names having to be fixed. Only your understanding on the database fixer is wrong.

learnt something new

Could those who tested this earlier, please test again, so that we can merge this?

@Hackwar You should adjust your testing instructions. The Database Fix will not run the insert statements in the schema update because it only handles DDL, as I mentioned in in my comment above. People either have to do a clean install or they have to run the insert statements from the schema update in PhpMyAdmin (or PgMyAdmin if PostgreSQL) after having applied the patch.

Please remove the composer.lock file

I have tested this item ? unsuccessfully on 822d13b

Work ok on a clean install
Does not work on an update - no submenus - and yes I did paste the sql into phpmyadmin

Unfortunaltely it is not wokring for me.

Submenu in the actual views has been removed but there are no 4 sub items in the menu.

I have tested this item ? unsuccessfully on 7e9fac5

Unfortunaltely it is not wokring for me.

see #24020 (comment)

@Hackwar For me this also doesn't work. The submenu items are gone after applying the patch but the Fix database and Menu Rebuild doesn't add it to the submenu.

I have tested this item ? unsuccessfully on 7e9fac5

@roland-d can you or one of the students confirm my finding that it was ok on a clean install. Also re your comment about database fix see #24020 (comment)

@brianteeman The test done by @bees4ever was on a clean installation as in he cloned the repo, installed J4 and did the test.

@roland-d can you or the students test #26137

I have tested this item ? unsuccessfully on 7e9fac5

not sure if I understand the right way.
point 4: if I do a new menu item "smart search" there is still only one submenu

Please test PR #27032