Feeling Lucky
?
NPM Resource Changed
?
?
[#24018] - [4.0] Media Manager create new folder: placeholder removed and text changed
- Fixed in Code Base
- 26 Feb 2019
- Medium
- Build: 4.0-dev
- # 24018
- Diff
- puneeth2001:placeholder
User tests: Successful: Unsuccessful:
Pull Request for Issue #20369
Summary of Changes
placeholder removed
save button changed
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Language & Strings |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
infograf768
- comment
- 26 Feb 2019
I have tested this item
After patch:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24018.
| Title |
|
||||||
Razzo1987
- comment
- 26 Feb 2019
I have tested this item
I see the new button, but I still see the paceholder.
After patch:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24018.
infograf768
- comment
- 26 Feb 2019
To test this, one needs to run npm ci on the test site. One can't just apply the patch.
zwiastunsw
- comment
- 26 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24018.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
infograf768
- comment
- 26 Feb 2019
RTC Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24018.
Razzo1987
- comment
- 26 Feb 2019
I have tested this item
sorry!
with npm ci works :D
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24018.
dneukirchen
- comment
- 26 Feb 2019
code lgtm, thx.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-26 13:35:38 |
| Closed_By | ⇒ | wilsonge |
@infograf768 @Quy can you please review this.