? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
26 Feb 2019

Pull Request for Issue #23933 cc @rolandalsace

Summary of Changes

With this changes we make sure you can not configure an child group as your parent. As well as now use the namespaced classes.

Testing Instructions

  • Install Joomla using testing sample data (or create a few nested groups)
  • check that the groups hierachie looks like this:
    image
  • now open the author group and check the allowed parent dropdown

Expected result

After applying the patch anything this are children of the current group is going to be removed from that list.
image

Actual result

Only the current group itself is removed from the list any other child is still there.
image

Documentation Changes Required

None.

a59a1c0 26 Feb 2019 avatar zero-24 2019
avatar zero-24 zero-24 - open - 26 Feb 2019
avatar zero-24 zero-24 - change - 26 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2019
Category Administration com_users
avatar zero-24 zero-24 - change - 26 Feb 2019
Labels Added: ?
avatar ladyjer ladyjer - test_item - 28 Feb 2019 - Tested successfully
avatar ladyjer
ladyjer - comment - 28 Feb 2019

I have tested this item successfully on 9d6cdcf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24021.

avatar ladyjer
ladyjer - comment - 28 Feb 2019

I have tested this item successfully on 9d6cdcf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24021.

avatar Quy
Quy - comment - 1 Mar 2019

It doesn't work for this case:
group1

group2

avatar zero-24
zero-24 - comment - 1 Mar 2019

@Quy @ladyjer please retest with the latest code provided. Please also test creation a new group

avatar Quy
Quy - comment - 1 Mar 2019

Call to undefined method JFormFieldGroupParent::checkTheChildren()

avatar zero-24
zero-24 - comment - 2 Mar 2019

You should not rename the method name after testing ... Fixed thanks @Quy

avatar Quy Quy - test_item - 2 Mar 2019 - Tested successfully
avatar Quy
Quy - comment - 2 Mar 2019

I have tested this item successfully on 4494375


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24021.

avatar HLeithner
HLeithner - comment - 2 Mar 2019

@ladyjer could you please test this PR again?

avatar alikon
alikon - comment - 7 Mar 2019

I have tested this item successfully on 38466d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24021.

avatar alikon alikon - test_item - 7 Mar 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2019

@Quy can you please retest?

avatar HLeithner HLeithner - change - 7 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-07 17:37:15
Closed_By HLeithner
avatar HLeithner HLeithner - close - 7 Mar 2019
avatar HLeithner HLeithner - merge - 7 Mar 2019
avatar HLeithner
HLeithner - comment - 7 Mar 2019

@franz-wohlkoenig Quy has already tested this commit thx.

@zero-24 thx for this PR.

Add a Comment

Login with GitHub to post a comment