[#23975] - [4.0] Moved error messages from the labels to the field controls.
- Closed
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 23975
- Diff
- ITPrism:error-message-field-control
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
The error message does not look good if I reduce the gap between the labels and the fields.
Testing Instructions
Merge this PR and generate the scripts.
npm run build:js
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
franz-wohlkoenig
- | Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository |
element.closest() needs a polyfill for ie so that will not work
This is no longer wrong as the production department have decided to adopt a browser support policy of PROD2019/005 - Change minimum version requirements for all browsers to n-2 and drop support for Internet Explorer. https://volunteers.joomla.org/departments/production/reports/1031-production-dept-meeting-may-28-2019
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
I have tested this item
The described behavior, I can not reproduce in the newest Joomla 4 version. The error message looks the same before and after applying the patch.
System:
PHP Build On: Windows NT 10.0 build 18362 (Windows 10) i586
10.1.37-MariaDB
PHP-Version: 7.3.0
Webserver: Apache/2.4.37 (Win32) OpenSSL/1.1.1a PHP/7.3.0
Joomla! Version: Joomla! 4.0.0-alpha12-dev Development [ Amani ] 19-August-2019 13:40 GMT
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23975.
I have tested this item
The described behavior, I can not reproduce in the newest Joomla 4 version. The error message looks the same before and after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23975.
I have tested this item
The error message looks the same before and after applying the patch on the newest Joomla 4 version.
System :
PHP Built On : Linux 4.15.0-58-generic #64-Ubuntu
Database Version : 10.4.6-MariaDB
PHP Version : 7.3.8
Web Server : Apache/2.4.39 (Unix) OpenSSL/1.0.2s PHP/7.3.8 mod_perl/2.0.8-dev Perl/v5.16.3
Joomla! Version : Joomla! 4.0.0-alpha12-dev Development [ Amani ] 19-August-2019 13:40 GMT
User Agent : Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23975.
I have tested this item
The PR is from february. Meanwhile the msg is different styled and the issue could not been reproduzed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23975.
Loks this way at the moment without the patch, so I think this PR can be removed:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23975.
Closing as reported above this is no longer required.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 12:58:50 |
| Closed_By | ⇒ | zero-24 |
No! You are doing it wrong!