? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Feb 2019

The asset title being created is COM_WORKFLOW_DEFAULT_WORKFLOW but it should be "Joomla Default"

The data in this table is used in the debug permissions view.

PR for #23794

avatar brianteeman brianteeman - open - 21 Feb 2019
avatar brianteeman brianteeman - change - 21 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2019
Category SQL Installation Postgresql
avatar SharkyKZ
SharkyKZ - comment - 22 Feb 2019

No, it shouldn't be translated. If you create a new workflow, its title won't be translated.

avatar brianteeman
brianteeman - comment - 22 Feb 2019

Sorry I don't understand your comment.

avatar SharkyKZ
SharkyKZ - comment - 22 Feb 2019

If you create a new workflow with language constant as title, it will appear untranslated in debug permissions view anyways. The same is true for workflow stages and component names.

avatar infograf768
infograf768 - comment - 23 Feb 2019

See:
#23794 (comment)

the issue is not only for that string.

avatar brianteeman brianteeman - change - 23 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-23 10:23:33
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 23 Feb 2019
avatar infograf768
infograf768 - comment - 23 Feb 2019

To solve this specific issue and most other not translated, we need to add
Factory::getLanguage()->load('com_workflow', JPATH_ADMINISTRATOR); in /administrator/components/com_users/Model/DebuguserModel.php`

populate state method
as well as add <?php echo $this->escape(Text::_($item->title)); ?>
in
administrator/components/com_users/tmpl/debuguser/default.php
It will not translate all assets possible, but many.

avatar infograf768
infograf768 - comment - 23 Feb 2019

If anyone interested I can make PR

avatar infograf768
infograf768 - comment - 23 Feb 2019

In fact, will do patch as we also need to add some new strings in com_users.ini to cope for all the Unpublished, Published, etc.

avatar infograf768
infograf768 - comment - 23 Feb 2019

Please test #23992

Add a Comment

Login with GitHub to post a comment