[#23831] - [4.0] Fixed login error color
- Closed
- 16 Apr 2019
- Medium
- Build: 4.0-dev
- # 23831
- Diff
- hardik-codes:ErrorColor
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23790
Summary of Changes
Changed color from #c6d2de to#d4d4d4 of span tag in administrator/templates/atum/scss/blocks/_login.scss
Testing Instructions
On the login page, without filling any credentials click Log In
Expected result
The color of the text 'Field value cannot be empty ' should be#d4d4d4
Actual result
The color of the text 'Field value cannot be empty ' was #c6d2de
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
@hardik-codes You can replace #d4d4d4 with var(--white-offset)
| Labels |
Added:
?
|
||
@C-Lodder and @dgrammatiko please review the changes
I tested this PR. In my case the var function did not work correctly. I see the text color: var(--white-offset); in the CSS file.
Am I doing something wrong?
Members please test this PR
@hardik-codes theres an unanswered Question by @astridx
This is no longer an issue with the new backend design.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-16 19:50:04 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2019-04-16 19:50:04 | ⇒ | 2019-04-16 19:50:05 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23831
Please see the new backend template.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23831.
Please see the new backend template.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23831.
@hardik-codes you need to use a variable from the_variables.scss instead of hardcoding the value here. @C-Lodder already proposed it in the issue