J4 Issue ? Success

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
8 Feb 2019

Pull Request for Issue #23790

Summary of Changes

Changed color from #c6d2de to#d4d4d4 of span tag in administrator/templates/atum/scss/blocks/_login.scss

Testing Instructions

On the login page, without filling any credentials click Log In

Expected result

The color of the text 'Field value cannot be empty ' should be#d4d4d4

Actual result

The color of the text 'Field value cannot be empty ' was #c6d2de

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 8 Feb 2019
avatar hardik-codes hardik-codes - change - 8 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2019
Category Administration Templates (admin)
avatar hardik-codes hardik-codes - change - 8 Feb 2019
Title
Fixed login error color
[4.0] Fixed login error color
avatar hardik-codes hardik-codes - edited - 8 Feb 2019
avatar dgrammatiko
dgrammatiko - comment - 8 Feb 2019

@hardik-codes you need to use a variable from the_variables.scss instead of hardcoding the value here. @C-Lodder already proposed it in the issue

avatar C-Lodder
C-Lodder - comment - 8 Feb 2019

@hardik-codes You can replace #d4d4d4 with var(--white-offset)

avatar hardik-codes hardik-codes - change - 8 Feb 2019
Labels Added: ?
avatar hardik-codes
hardik-codes - comment - 8 Feb 2019

@C-Lodder and @dgrammatiko please review the changes

avatar astridx
astridx - comment - 9 Feb 2019

I tested this PR. In my case the var function did not work correctly. I see the text color: var(--white-offset); in the CSS file.

Am I doing something wrong?

bildschirmfoto von 2019 02 09 21 20 54

avatar hardik-codes
hardik-codes - comment - 8 Mar 2019

Members please test this PR

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Mar 2019

@hardik-codes theres an unanswered Question by @astridx

avatar hardik-codes
hardik-codes - comment - 14 Mar 2019

I tested this PR. In my case the var function did not work correctly. I see the text color: var(--white-offset); in the CSS file.

Am I doing something wrong?

bildschirmfoto von 2019 02 09 21 20 54

@astridx
I think you need to run npm run build:css to compile the scss, after applying the patch

avatar hardik-codes
hardik-codes - comment - 16 Mar 2019

@astridx Was your issue resolved ?

avatar Quy
Quy - comment - 15 Apr 2019

This is no longer an issue with the new backend design.

login

avatar Quy Quy - change - 16 Apr 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-04-16 19:50:04
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2019
Closed_Date 2019-04-16 19:50:04 2019-04-16 19:50:05
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 16 Apr 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Apr 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23831

avatar Quy
Quy - comment - 16 Apr 2019

Please see the new backend template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23831.

avatar Quy
Quy - comment - 16 Apr 2019

Please see the new backend template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23831.

Add a Comment

Login with GitHub to post a comment