[#23829] - [4.0] Removing special layouts for com_contact
- Fixed in Code Base
- 18 Apr 2019
- Medium
- Build: 4.0-dev
- # 23829
- Diff
- Hackwar:j4contactlayouts
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
The special layouts of com_contact (displaying contacts in sliders, tabs or plain) are stupid. We have no other output that you can switch like this. So this PR removes that feature.
How to test
Create a new contact and see that you can't select a presentation style for this. Likewise in menu items and the global configuration for com_contact. See in the frontend that a contact is only displayed in plain style.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Front End |
Qualifying this feature as stupid is your analysis.
Let's each one select what they want as it is already available.
Fully agree with this.
Easier to maintain and users can create an override, should they wish to change the structure
Let's each one select what they want as it is already available.
Then re-implement it as alternative layouts instead of shoving what is in essence three different layout styles into one template (basically doing the same as default and blog category layouts for articles). I don't think the feature is "stupid" necessarily but the implementation just sucks and makes building overrides more complex than necessary because you have to decipher what code belongs to what layout option and account for a lot of scenarios that might not exist if you're going for the plain style.
If you are going to remove the options then you also should remove the language strings
Excuse my language. Displaying the contact in sliders or tabs is of course not stupid, but as @mbabker wrote, the implementation is among the worst that I can think of.
@brianteeman going to remove the language strings now.
| Labels |
Added:
?
|
||
| Category | Administration com_contact Front End | ⇒ | Administration com_contact Language & Strings Front End |
| Labels |
Added:
?
|
||
I tested this PR and I like it. In my opinion, the presentation belongs only to the template.
But: Does not the parameter have to be deleted here
https://github.com/joomla/joomla-cms/blob/ad2c673ac27c2fd19bbdf6003aee0451d068de16/installation/sql/mysql/joomla.sql#L521
and here
https://github.com/joomla/joomla-cms/blob/ad2c673ac27c2fd19bbdf6003aee0451d068de16/installation/sql/postgresql/joomla.sql#L531
Hello @astridx, thanks for your test. Yes, the parameter data is still there in the SQL, but it will simply be ignored. When the data is loaded, that key-value-pair will simply not be added anywhere and if you save the global config of com_contact the next time, this would be gone. I've not deleted these entries because I'm a bit lazy and I expect us to at one time to update all these parameters from the XML source anyway before 4.0 is released.
franz-wohlkoenig
- | Category | Administration com_contact Front End Language & Strings | ⇒ | Administration com_contact Front End |
| Labels |
Removed:
J4 Issue
|
||
| Category | Administration com_contact Front End | ⇒ | Administration com_contact Language & Strings Front End |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-18 11:36:20 |
| Closed_By | ⇒ | wilsonge |
Thank you!
Related issue.. #15345