Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23730] - [4.0] Hidden-mail custom element improvements

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
31 Jan 2019

Summary of Changes

Improvements to the Hidden-mail custrom element

  • Cache some values in the constructor
  • ESLint fixes
  • Use static method where applicable

Testing Instructions

  1. Create a custom module
  2. Enable the Prepare Content option
  3. In the editor, type in a couple of email addresses

Expected result

Exactly the same result as before the patch

To-do

  • Need to look further into how Custom Elements are actually made async using a mutation observer, but that can be done in a separate PR
avatar C-Lodder C-Lodder - open - 31 Jan 2019
avatar C-Lodder C-Lodder - change - 31 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2019
Category ⇒ JavaScript Repository
avatar C-Lodder C-Lodder - change - 31 Jan 2019
The description was changed
avatar C-Lodder C-Lodder - edited - 31 Jan 2019
avatar C-Lodder C-Lodder - change - 31 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2019
Category JavaScript Repository ⇒ JavaScript Repository NPM Change
avatar wilsonge wilsonge - change - 23 Feb 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-23 16:50:48
Closed_By ⇒ wilsonge
Labels Added: NPM Resource Changed
avatar wilsonge wilsonge - close - 23 Feb 2019
avatar wilsonge wilsonge - merge - 23 Feb 2019
avatar wilsonge
wilsonge - comment - 23 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment