Feeling Lucky
NPM Resource Changed
?
[#23729] - [4.0] Permissions custom element improvements
- Fixed in Code Base
- 23 Feb 2019
- Medium
- Build: 4.0-dev
- # 23729
- Diff
- C-Lodder:ce-permissions
User tests: Successful: Unsuccessful:
Summary of Changes
Rework the Permissions Custom Element
- Cache variables in the constructor
- Decouple FontAwesome
- Make use of identical operators
- Eslint fixes
Testing Instructions
- To go the
permissionstab in Global Configuration - Change the permission for different actions
Expected result
- Refresh and ensure the permission you selected is still set
- Ensure the icons are visible
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Title |
|
||||||
| Labels |
Added:
?
|
||
C-Lodder
- comment
- 31 Jan 2019
@brianteeman As far as I know there are 2 types of custom elements. Those that are replacements for Bootstrap components and live in a standalone repo, and those that are part of Joomla core that live in this repo.
brianteeman
- comment
- 31 Jan 2019
Thanks for the clarification
Anu1601CS
- comment
- 31 Jan 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23729.
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-23 16:27:37 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 23 Feb 2019
Thanks!
Shouldnt these be done upstream in the webcomponents repo?