? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
24 Jan 2019

Summary of Changes

Adjusting the check for the index.php file the template controller to match what is actually passed in the request.

Testing Instructions

In the template file manager, try to delete and rename the index.php file of a template

Expected result

A warning message and the file isn't deleted/renamed

Actual result

File is deleted/renamed without any warning.

Documentation Changes Required

None

avatar Bakual Bakual - open - 24 Jan 2019
avatar Bakual Bakual - change - 24 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2019
Category Administration com_templates
avatar ghazal
ghazal - comment - 24 Jan 2019

Re : joomla 4
By accident, I applied test and both corrections to Joomla 4

  • test as described above (index.php is deleted)
  • both corrections work (index.php can't be deleted + message)

Corrections applied to:
/administrator/components/com_templates/Controller/TemplateController.php

avatar Bakual Bakual - change - 24 Jan 2019
Labels Added: ?
avatar Bakual Bakual - change - 24 Jan 2019
The description was changed
avatar Bakual Bakual - edited - 24 Jan 2019
avatar Bakual
Bakual - comment - 24 Jan 2019

@ghazal Yep, same bug exists in J4 as well.

Updated test instructions since I saw that the rename button has the exact same issue.

avatar ghazal
ghazal - comment - 24 Jan 2019

I have tested this item successfully on 3133774

@Bakual
thank you for pointing this out.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23654.

avatar ghazal ghazal - test_item - 24 Jan 2019 - Tested successfully
avatar viocassel
viocassel - comment - 24 Jan 2019

I have tested this item successfully on 3133774


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23654.

avatar viocassel viocassel - test_item - 24 Jan 2019 - Tested successfully
avatar Quy Quy - change - 24 Jan 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23654.

avatar HLeithner HLeithner - change - 2 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-02 16:23:23
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 2 Feb 2019
avatar HLeithner HLeithner - merge - 2 Feb 2019
avatar HLeithner
HLeithner - comment - 2 Feb 2019

thx

Add a Comment

Login with GitHub to post a comment