[#23655] - [4.0] Remove file from template url
- Closed
- 2 Aug 2020
- Medium
- Build: 4.0-dev
- # 23655
- Diff
- Bakual:RemoveFileFromTemplateURL
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Currently in the template file manager, the URL argument file is always present, even when no file is actually edited. This isn't necessary and is a bit confusing in the code.
Summary of Changes
This PR removes all instances where the argument isn't necessary and adjusts the checks.
There will be a small difference in behavior: Currently you can execute non-edit-related actions (eg create override or delete a folder) and after the redirect the previously opened file will still be open. After this patch it will be closed.
Keep in mind that even currently, all changes made in that file since the last save would be lost if you run such an action. So it gives a wrong impression to always reopen it.
Imho, the edit mode should disable all other tabs and non-edit buttons. To prevent the data loss. But that would be a task for another PR.
I also removed the hidden compressed_formats parameter and related checks. Since it was a hidden parameter with only zip as value, it basically was a hardcoded to 'zip'. I instead just really hardcoded it into the code.
Testing Instructions
Play around with the template file manager and see if something is broken.
Especially also try the various file manipulations (edit, create, delete, copy, resize, crop, ...)
Expected result
Works as before
Actual result
No difference
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates SQL Installation Postgresql |
Conflicts solved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23655.
I have tested this item
From #JMAD19 PBF, Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23655.
Nah, I'm closing this as I would have to do it fresh again. It's not that important :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-02 11:24:52 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
Conflicting Files
|
||
Can you look at resolving the conflicts so that this can be tested please.