[#23653] - [4.0] Remove libraries/cms/html/language/en-GB/en-GB.jhtmldate.ini
- Fixed in Code Base
- 2 Feb 2019
- Medium
- Build: staging
- # 23653
- Diff
- Bakual:RemoveJhtmldate
User tests: Successful: Unsuccessful:
Summary of Changes
This PR removes the language file libraries/cms/html/language/en-GB/en-GB.jhtmldate.ini.
The file isn't in a regular language folder where it could be loaded, and the strings in it are also present in the lib_joomla.ini one.
Testing Instructions
Check the Users -> Users Action Logs view
The column "Date" uses the strings in that file.
Expected result
Actual result
Same as expected
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Libraries |
I have tested this item
Weird. Wonder why we had the same situation (strings in both files) in 2.5...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23653.
| Status | Pending | ⇒ | Ready to Commit |
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23653.
It could be being used by an extension.
This should not be in a patch update as it would not be in accordance with semver.
Even if the logger wont pick it up it should be deprecated before removal
It could be being used by an extension.
How? You can't load this file as it is not in a supported folder. And even if that worked, the file just wouldn't be loaded but the strings are still there.
But then I don't mind if this goes into 3.x or 4.0. Just let me know when I have to rebase the PR.
If the file exists then someone can use it (even if they shouldn't or have to jump through hoops)
| Labels |
Added:
?
|
||
| Category | Administration com_admin Libraries | ⇒ | Unit Tests Repository Administration com_admin |
Redone against 4.0 branch.
| Title |
|
||||||
| Category | Administration com_admin Unit Tests Repository | ⇒ | Libraries |
How? You can't load this file as it is not in a supported folder.
$language->load('jhtmldate', JPATH_LIBRARIES . '/cms/html');The only restriction in the language API (which I never liked but ¯\_(ツ)_/¯) is that there must be a directory named "language" within the path you specify. Other than that, you can put language files anywhere in the filesystem. Whether the CMS UI supports those locations is another story.
Wonder why we had the same situation (strings in both files) in 2.5...
When the Platform was a standalone thing it was decided to put language files into the library packages.
Other than that, you can put language files anywhere in the filesystem.
Thanks. I wasn't even aware you can do that.
Restarted drone.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-02 17:40:46 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on a97ca73
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23653.