? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
31 Dec 2018

Pull Request for Issue # .

Summary of Changes

  • Added a new method in core.js
  /**
   * Method that resets given inputs and submits the given form
   * @param {HTMLElement}  The element that initiates the call
   */
  Joomla.resetFilters = (element) => { }
  • Changed all the xml filters to use this method
  • The method will reset all the fields of the filters form only except:
    -- the task
    -- the token
    -- the boxcheked

Testing Instructions

Go to Admin templates, check if the site/admin dropdown resets the table options
screenshot 2018-12-31 at 21 53 28

Expected result

Actual result

Documentation Changes Required

Yes.
Basically to implement the filter reset one just needs to add in the XML:

		onchange="Joomla.resetFilters(this)"

That simple

avatar dgrammatiko dgrammatiko - open - 31 Dec 2018
avatar dgrammatiko dgrammatiko - change - 31 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2018
Category Unit Tests Repository Administration com_admin
avatar infograf768
infograf768 - comment - 1 Jan 2019

Change missing for filter_modulesadmin.xml

782c422 1 Jan 2019 avatar dgrammatiko more
avatar dgrammatiko dgrammatiko - change - 1 Jan 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2019
Category Unit Tests Repository Administration com_admin Administration com_associations com_languages com_modules com_templates JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 1 Jan 2019
The description was changed
avatar dgrammatiko dgrammatiko - edited - 1 Jan 2019
avatar dgrammatiko dgrammatiko - change - 1 Jan 2019
Labels Added: ?
Removed: ?
5f60d65 1 Jan 2019 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 1 Jan 2019
The description was changed
avatar dgrammatiko dgrammatiko - edited - 1 Jan 2019
avatar dgrammatiko dgrammatiko - change - 1 Jan 2019
Title
[4.0][WIP] No jQuery in the xml files...
[4.0] No jQuery in the xml files...
avatar dgrammatiko dgrammatiko - edited - 1 Jan 2019
avatar wilsonge wilsonge - change - 2 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-02 22:28:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Jan 2019
avatar wilsonge wilsonge - merge - 2 Jan 2019
avatar wilsonge
wilsonge - comment - 2 Jan 2019

Looks good to me :)

Add a Comment

Login with GitHub to post a comment