[#23417] - [4.0] no jquery workflow button
- Fixed in Code Base
- 5 Jan 2019
- Medium
- Build: 4.0-dev
- # 23417
- Diff
- dgrammatiko:4.0-dev-nojquery-toolbar
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Removes a
jQuery('something').nextAll().toggle('else');
FWIW https://plainjs.com got all the answers you need.
Eg for this one:
https://plainjs.com/javascript/traversing/get-siblings-of-an-element-40/
Testing Instructions
Workflow in the articles still works fine
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Layout |
@bembelimen that's because I'm an idiot, https://github.com/joomla/joomla-cms/pull/23417/files#diff-4bf6113582ca75b8b0e2f8e2dd64d87aR49
this needs to be "Joomla.toggleAllNextElements(this, 'd-none')"
| Labels |
Added:
?
|
||
I sent you a PR to fix this error.
@bembelimen should be fine now
BTW as these buttons are part of the JGrid (or whatever is the name of the class that builds the table rows) I would suggest to make the layout more generic (in the root/layouts) and also move the js file to somewhere like media/system/layouts/whatever-name-of-the-layout/name-of-the-script.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23417.
I have tested this item
No error messages and workflow is working correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23417.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23417.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-05 18:50:11 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I got the following error:
