Joomla! Issue Tracker | Joomla! CMS #23407 - [4.0] Prevent loading LoadingLayer twice

NPM Resource Changed ? ?

Fixed in Code Base
27 Feb 2019
Medium
Build: 4.0-dev
# 23407
Diff
bembelimen:loading-layer-prevent-twice

Pending

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success continuous-integration/drone/pr the build was successful Details
Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

bembelimen
31 Dec 2018

Summary of Changes

Joomla has an internal LoadingLayer which appears if you change e.g. the category in an article while having custom fields.

This layer could be generated unlimited times by calling Joomla.loadingLayer('load'); but this make no sense. This PR prevents multi loading of this layer

Testing Instructions

open the edit form of an article
open your developer console in your browser
type in Joomla.loadingLayer('load');

Expected result

only one instance of the layer is created

Actual result

unlimited layers are creatable

Documentation Changes Required

428d7f4 31 Dec 2018

Prevent loading LoadingLayer twice

bembelimen - open - 31 Dec 2018

bembelimen - change - 31 Dec 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 31 Dec 2018

Category

⇒

JavaScript Repository

b268ffd 31 Dec 2018

Tabs to spaces

bembelimen - change - 31 Dec 2018

Labels

Added: ?

df9a13f 31 Dec 2018

Add return value

dgrammatiko - comment - 31 Dec 2018

joomla-cms/media/system/js/core-uncompressed.js

Lines 797 to 814 in 25564d8

    
           	/** 
        
           	 * Add Joomla! loading image layer. 
        
           	 * 
        
           	 * Used in: /administrator/components/com_installer/views/languages/tmpl/default.php 
        
           	 *          /installation/template/js/installation.js 
        
           	 * 
        
           	 * @param   {String}       task           The task to do [load, show, hide] (defaults to show). 
        
           	 * @param   {HTMLElement}  parentElement  The HTML element where we are appending the layer (defaults to body). 
        
           	 * 
        
           	 * @return  {HTMLElement}  The HTML loading layer element. 
        
           	 * 
        
           	 * @since  3.6.0 
        
           	 * 
        
           	 * @deprecated  4.0 No direct replacement. 
        
           	 *              4.0 will introduce a web component for the loading spinner, therefore the spinner will need to 
        
           	 *              explicitly be loaded in all relevant pages. 
        
           	 */ 
        
           	Joomla.loadingLayer = function(task, parentElement) {

This method will be removed

mbabker - comment - 31 Dec 2018

Bug fixes really should go to staging if they apply there (hint, this one does)
Even if something is deprecated, until it is removed there is no reason to block optimizations/changes to the deprecated element (well, short of adding new functionality unless it is to help bridge to the replacement); if the web component is ready then it should be in use and this method removed otherwise at best it is just a note stating an intention.

dgrammatiko - comment - 31 Dec 2018

there is no reason to block optimizations/changes

I wasn't meant to block but defer to the staging. I guess I need to write a bit more text on these comments...

mbabker - comment - 31 Dec 2018

Lesson I learned the hard way, short and direct doesn't always communicate well ?

PhocaCz - comment - 5 Jan 2019

I have tested this item ✅ successfully on df9a13f

I do not know what is the state of this PR for now but I get the same results when applying the patch/without applying the patch:

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23407.}

PhocaCz - test_item - 5 Jan 2019 - Tested successfully

cf97ada 26 Feb 2019

Merge branch '4.0-dev' of github.com:joomla/joomla-cms into loading-layer-prevent-twice

joomla-cms-bot - change - 26 Feb 2019

Category

JavaScript Repository

⇒

JavaScript Repository NPM Change

chmst - test_item - 27 Feb 2019 - Tested successfully

chmst - comment - 27 Feb 2019

I have tested this item ✅ successfully on cf97ada

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23407.}

HLeithner - change - 27 Feb 2019

Title

…

Prevent loading LoadingLayer twice

[4.0] Prevent loading LoadingLayer twice

HLeithner - edited - 27 Feb 2019

Quy - change - 27 Feb 2019

Status

Pending

⇒

Ready to Commit

Quy - comment - 27 Feb 2019

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23407.}

5aa785b 27 Feb 2019

Merge branch '4.0-dev' into loading-layer-prevent-twice

wilsonge - change - 27 Feb 2019

Labels

Added: ?

wilsonge - change - 27 Feb 2019

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2019-02-27 16:09:46
Closed_By		⇒	wilsonge
Labels	Added: NPM Resource Changed

wilsonge - close - 27 Feb 2019

wilsonge - merge - 27 Feb 2019

wilsonge - comment - 27 Feb 2019

Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#23407] - [4.0] Prevent loading LoadingLayer twice

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Add a Comment

	/**
	* Add Joomla! loading image layer.
	*
	* Used in: /administrator/components/com_installer/views/languages/tmpl/default.php
	* /installation/template/js/installation.js
	*
	* @param {String} task The task to do [load, show, hide] (defaults to show).
	* @param {HTMLElement} parentElement The HTML element where we are appending the layer (defaults to body).
	*
	* @return {HTMLElement} The HTML loading layer element.
	*
	* @since 3.6.0
	*
	* @deprecated 4.0 No direct replacement.
	* 4.0 will introduce a web component for the loading spinner, therefore the spinner will need to
	* explicitly be loaded in all relevant pages.
	*/
	Joomla.loadingLayer = function(task, parentElement) {